From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752788AbbC3KXF (ORCPT ); Mon, 30 Mar 2015 06:23:05 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:12180 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752596AbbC3KXB (ORCPT ); Mon, 30 Mar 2015 06:23:01 -0400 X-AuditID: cbfee68f-f791c6d000004834-af-551924031fa5 Date: Mon, 30 Mar 2015 10:22:59 +0000 (GMT) From: MyungJoo Ham Subject: Re: [PATCH v6 2/8] PM / devfreq: tegra: Update to v5 of the submitted patches To: Tomeu Vizoso , "linux-tegra@vger.kernel.org" Cc: Mikko Perttunen , Alex Frid , =?utf-8?Q?=EB=B0=95=EA=B2=BD=EB=AF=BC?= , Stephen Warren , Thierry Reding , Alexandre Courbot , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Reply-to: myungjoo.ham@samsung.com MIME-version: 1.0 X-MTR: 20150330101906638@myungjoo.ham Msgkey: 20150330101906638@myungjoo.ham X-EPLocale: ko_KR.utf-8 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20150330101906638@myungjoo.ham X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general Content-type: text/plain; charset=utf-8 MIME-version: 1.0 Message-id: <1040887254.91981427710975821.JavaMail.weblogic@epmlwas08a> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEIsWRmVeSWpSXmKPExsWyRsSkUJdFRTLU4NcRFovLu+awOTB6fN4k F8AYxWWTkpqTWZZapG+XwJUx7Vk7S8Eb6Ypni5rZGhh7pLsYOTmEBNQlFi05yQZiSwiYSGxe 8JcdwhaTuHBvPRtEzVJGiX9Li2FqvkxvZoaIz2GU6P5fAWKzCKhKXPz4iLWLkYODTUBPYubn ZJCwsECYxJMPn5lAbBGBPIk3px8DlXBxMAvMYpbY+e4zK8QcJYk1+16xgNi8AoISJ2c+YYHY pSqx/clsVoi4msSjVYuh7hSXuDD3EtSdvBIz2p9C1ctJTPu6hhnClpY4P2sDI8wvi78/horz Sxy7vYMJwhaQmHrmIFSNlsTLfy9YIWw+iTUL37LA1O86tZwZZtf9LXOheiUktrY8AatnFlCU mNL9kB3kd2YBTYn1u/TRvcIr4C7xbMIOdpDfJQSmckisOnKbaQKj0iwkdbOQjJqFMApZyQJG llWMoqkFyQXFSelFxnrFibnFpXnpesn5uZsYgUnh9L9n/TsY7x6wPsQowMGoxMPrUC8RKsSa WFZcmXuI0RQYSxOZpUST84GpJ68k3tDYzMjC1MTU2Mjc0kxJnHeh1M9gIYH0xJLU7NTUgtSi +KLSnNTiQ4xMHJxSDYyVXN7yP6Ie7d04pzJYt+zu5MC1S8XtZmdwMUe0fXJ6e+uBNJPPOtHg BK/83R21SZ8q6519v/RM1JV+uYrpuLrwOdZCh39hLdVZJt5TMvInHHp45+/qC7N+H8lun+zU 87+rxGWap/t+QaenVdplXLfW/Ck4vXzLcr5V/jm617bfPMDckvv86G4lluKMREMt5qLiRAD8 w0TvBQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCKsWRmVeSWpSXmKPExsVy+t/tXl1mFclQg569VhaXd81hc2D0+LxJ LoAxKs0mIzUxJbVIITUvOT8lMy/dVsk7ON453tTMwFDX0NLCXEkhLzE31VbJxSdA1y0zB2io kkJZYk4pUCggsbhYSd/Opii/tCRVISO/uMRWKdrQ3EjPyEDP1EjP0DjWytDAwMgUqCYhLWPa s3aWgjfSFc8WNbM1MPZIdzFycggJqEssWnKSDcSWEDCR+DK9mRnCFpO4cG89G0TNHEaJ7v8V IDaLgKrExY+PWLsYOTjYBPQkZn5OBgkLC4RJPPnwmQnEFhHIk3hz+jFQCRcHs8AsZomd7z6z QsxRkliz7xULiM0rIChxcuYTFohdqhLbn8xmhYirSTxatRjqHnGJC3MvsUPYvBIz2p9C1ctJ TPu6BupOaYnzszYwwty8+PtjqDi/xLHbO5ggbAGJqWcOQtVoSbz894IVwuaTWLPwLQtM/a5T y5lhdt3fMheqV0Jia8sTsHpmAUWJKd0P2UF+ZxbQlFi/Sx/dK7wC7hLPJuxgn8AoOwtJahaS 7lkI3chKFjCyrGIUTS1ILihOSq8w0StOzC0uzUvXS87P3cQITkHPluxgbLhgfYhRgINRiYfX oV4iVIg1say4MvcQowQHs5IIryWvZKgQb0piZVVqUX58UWlOavEhRlNgnE1klhJNzgemx7yS eENjYxMzE1NLEwsDU3Mlcd7/53JDhATSE0tSs1NTC1KLYPqYODilGhgdbDZ8PFts6Lzx1Jb4 T3fdSle5Ok92EWR7n6LxVnAO/14OpeOMyU1BagkTq7Ok/whlXLGe2pfH6flMT5lDe0tT0pur mk9YnrBs4Cp9ffVZnME9Vq5kfpv9e3kaT0ueiVni+D5vrqju5yrmS/PXhOjLTGg9I971q3rH U2+59Xs5dK3ctzW0KCixFGckGmoxFxUnAgBHmF2pVwMAAA== DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t2UAND4J017645 > Sender : Tomeu Vizoso > Date : 2015-03-17 18:36 (GMT+09:00) > Title : [PATCH v6 2/8] PM / devfreq: tegra: Update to v5 of the submitted patches > > There seemed to be some miscommunication and an old version of the > submitted patches was merged. > > This commit updates the driver to v5, which had this changelog: > > * Clarify the units of avg_dependency_threshold > * Remove unused references to platform_device > * Enable and disable interrupts on governor events > * Make sure we handle all interrupts for any of the devices we are sampling > * Move locking to be per-actmon-device > > Signed-off-by: Tomeu Vizoso > CC: Alex Frid > CC: Mikko Perttunen > --- > drivers/devfreq/tegra-devfreq.c | 455 ++++++++++++++++++++++------------------ > 1 file changed, 252 insertions(+), 203 deletions(-) > > diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c > index 3479096..c71635a 100644 > --- a/drivers/devfreq/tegra-devfreq.c > +++ b/drivers/devfreq/tegra-devfreq.c [] > -static struct devfreq_dev_profile tegra_devfreq_profile = { > - .polling_ms = 0, > - .target = tegra_devfreq_target, > - .get_dev_status = tegra_devfreq_get_dev_status, > -}; > +static int __init tegra_governor_init(void) > +{ > + return devfreq_add_governor(&tegra_devfreq_governor); > +} > +subsys_initcall(tegra_governor_init); > [] It looks like you need to disable "module" in the corresponding Kconfig. Do you want to add another patch to make it compilable as a module? or do you want to make it "tristate" --> "bool"? If you want the latter, I can do it for you before I send a pull request. Please refer to the following: mzx@kohaku:/home/kernel.org/devfreq$ make ARCH=arm modules CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelease.h make[1]: `include/generated/mach-types.h' is up to date. CALL scripts/checksyscalls.sh CC [M] drivers/devfreq/tegra-devfreq.o drivers/devfreq/tegra-devfreq.c:758:1: error: redefinition of ‘__inittest’ drivers/devfreq/tegra-devfreq.c:613:1: note: previous definition of ‘__inittest’ was here drivers/devfreq/tegra-devfreq.c:758:1: error: redefinition of ‘init_module’ drivers/devfreq/tegra-devfreq.c:613:1: note: previous definition of ‘init_module’ was here make[2]: *** [drivers/devfreq/tegra-devfreq.o] Error 1 make[1]: *** [drivers/devfreq] Error 2 make: *** [drivers] Error 2 mzx@kohaku:/home/kernel.org/devfreq$ Cheers, MyungJoo {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I