From: Marcel Holtmann <marcel@holtmann.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
akpm@zip.com.au, Thomas Sailer <sailer@ife.ee.ethz.ch>,
Jose Orlando Pereira <jop@di.uminho.pt>,
J.E.J.Bottomley@HansenPartnership.com
Subject: Re: [PATCH] Deprecate exec_usermodehelper, fix request_module.
Date: 02 Jan 2003 18:14:17 +0100 [thread overview]
Message-ID: <1041527666.16046.18.camel@pegasus.local> (raw)
In-Reply-To: <20030102093637.8C6892C2FB@lists.samba.org>
Hi Rusty,
> I got a report from Urban Widmark that modprobe dropped its privs on
> executing an install command: turns out request_module
> (ie. exec_usermodehelper) doesn't set the real uid or gid (so bash
> drops privs).
>
> These efforts to "clean" the current process are *always* going to be
> buggy: we should use the event thread all the time, rather than
> forking a random thread and trying to clean it. This fixes
> request_module to do that (kevent threads can't block, so we
> double-fork).
>
> There are still three
> (obscure) users of exec_usermodehelper in the tree:
>
> drivers/net/hamradio/baycom_epp.c
> drivers/bluetooth/bt3c_cs.c
> arch/i386/mach-voyager/voyager_thread.c
for the bt3c_cs driver I need to run a user space program that downloads
the firmware into the card and the kernel part have to wait until this
program has finished. So what is the best way to do this now?
Regards
Marcel
next prev parent reply other threads:[~2003-01-02 17:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-02 9:36 [PATCH] Deprecate exec_usermodehelper, fix request_module Rusty Russell
2003-01-02 17:14 ` Marcel Holtmann [this message]
2003-01-02 19:08 ` Thomas Sailer
2003-01-03 5:08 ` Rusty Russell
2003-01-03 6:21 ` Brad Hards
2003-01-03 7:25 ` Jeff Garzik
2003-01-03 7:36 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1041527666.16046.18.camel@pegasus.local \
--to=marcel@holtmann.org \
--cc=J.E.J.Bottomley@HansenPartnership.com \
--cc=akpm@zip.com.au \
--cc=jop@di.uminho.pt \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=sailer@ife.ee.ethz.ch \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox