From: Michael Meeks <michael@ximian.com>
To: linux-kernel@vger.kernel.org
Cc: evolution <evolution-hackers@ximian.com>, orbit <orbit-list@gnome.org>
Subject: unix_getname buglet - > 2.5.4(?)
Date: 07 Jan 2003 12:06:32 +0000 [thread overview]
Message-ID: <1041941192.25619.293.camel@michael.home> (raw)
Hi there,
Evolution is non-functioning on recent 2.5.X kernels, due to
mal-performance in getpeername => net/unix/af_unix.c (unix_getname),
where it seems we switch 'sk' on 'peer', but not the (previously)
typecast pointer to it; this fixes it.
--- af_unix.c.old Tue Jan 7 11:59:09 2003
+++ af_unix.c Tue Jan 7 12:00:45 2003
@@ -1097,7 +1097,7 @@
static int unix_getname(struct socket *sock, struct sockaddr *uaddr,
int *uaddr_len, int peer)
{
struct sock *sk = sock->sk;
- struct unix_sock *u = unix_sk(sk);
+ struct unix_sock *u;
struct sockaddr_un *sunaddr=(struct sockaddr_un *)uaddr;
int err = 0;
@@ -1112,6 +1112,7 @@
sock_hold(sk);
}
+ u = unix_sk(sk);
unix_state_rlock(sk);
if (!u->addr) {
sunaddr->sun_family = AF_UNIX;
Thanks Joaquim Fellmann (AFAIR) who chased this down to bitkeeper
changeset 1.262.2.2. Sadly I didn't have time to read the rest of that
changeset to see if the mistake pops up elsewhere as well. Please CC me
with replies, not on linux-kernel.
HTH,
Michael Meeks.
--
mmeeks@gnu.org <><, Pseudo Engineer, itinerant idiot
next reply other threads:[~2003-01-07 12:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-07 12:06 Michael Meeks [this message]
2003-01-07 18:11 ` [PATCH] Re: unix_getname buglet - > 2.5.4(?) Ray Lee
2003-01-09 0:14 ` Andy Pfiffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1041941192.25619.293.camel@michael.home \
--to=michael@ximian.com \
--cc=evolution-hackers@ximian.com \
--cc=linux-kernel@vger.kernel.org \
--cc=orbit-list@gnome.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox