From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752075AbdCNOGd (ORCPT ); Tue, 14 Mar 2017 10:06:33 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:48403 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751557AbdCNOGa (ORCPT ); Tue, 14 Mar 2017 10:06:30 -0400 X-AuditID: b6c32a58-f79f16d00000132c-55-58c7f8e2175f From: Bartlomiej Zolnierkiewicz To: Krzysztof Kozlowski Cc: Catalin Marinas , Will Deacon , Kukjin Kim , Javier Martinez Canillas , Arnd Bergmann , Kevin Hilman , Olof Johansson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 2/3] soc: samsung: Do not build ARMv7 PMU drivers on ARMv8 Date: Tue, 14 Mar 2017 15:06:23 +0100 Message-id: <10434341.iCgJC0vsO4@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170311213856.21701-3-krzk@kernel.org> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGKsWRmVeSWpSXmKPExsWy7bCmuu6jH8cjDJrmSVv8nXSM3eL9sh5G izdv1zBZ9D9+zWzxs30Lk8X58xvYLTY9vsZqcXnXHDaLGef3MVmcuv6ZzeLlxxMsDtwea+at YfT4/WsSo8f7G63sHptWdbJ5bF5S73HlRBOrx5b+u+wenzfJBXBEcdmkpOZklqUW6dslcGWs PPOMpeAuZ8XtjgPsDYwv2bsYOTkkBEwkds49zQphi0lcuLeeDcQWEljKKLF5sXAXIxeQ3c4k cWzne0aYhhOP3jBCJOYwSjSeucME4XxllJi88ykzSBWbgJXExPZVYB0iApoS1/9+ZwUpYhb4 wSSxeNEzsISwQIDEif39YLtZBFQlZp89DnYTr4CWRFPrIbC4qICXxJZ97UwgNqeAqcTql21s EDWCEj8m32MBsZkF5CX27Z/KCmHrSJw9tg7sPAmBW+wSnV1/gBIcQI6sxKYDzBAvuEi8fPkC 6h1hiVfHt0DDQlri79JbUPHpjBLbf0tAzNnMKLFq9wSoImuJw8cvQi3jk+j9/YQJYj6vREeb EESJh8TuL0ug5jhKdLy7xw4JIaA5rzrPsE9glJ+F5IdZSH6YheSHBYzMqxjFUguKc9NTi00L TPSKE3OLS/PS9ZLzczcxglOTVsQOxn8zgg4xCnAwKvHwbvh0PEKINbGsuDL3EKMEB7OSCO/l r0Ah3pTEyqrUovz4otKc1OJDjNIcLErivFEGEyOEBNITS1KzU1MLUotgskwcnFINjJbZVonf /Y227zISXLyz3bMv+NepHzkcX69/q1ZYwub56o5GQrnAmvNmRYFO/zhcp7jv/bWvQXzNPHuO rp0c68+3pHd/n/lUXSTyooWt5oePYh9eKTtMfD1v9uU3+l2h0aXtx//+ffuBY5KnzKnU/V3i F8N5NnHEP+v0qZj548r9uKgHCz+ltiuxFGckGmoxFxUnAgB0kiTESQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBIsWRmVeSWpSXmKPExsVy+t9jQd2HP45HGJx4Z23xd9Ixdov3y3oY Ld68XcNk0f/4NbPFz/YtTBbnz29gt9j0+BqrxeVdc9gsZpzfx2Rx6vpnNouXH0+wOHB7rJm3 htHj969JjB7vb7Sye2xa1cnmsXlJvceVE02sHlv677J7fN4kF8AR5WaTkZqYklqkkJqXnJ+S mZduqxQa4qZroaSQl5ibaqsUoesbEqSkUJaYUwrkGRmgAQfnAPdgJX27BLeMlWeesRTc5ay4 3XGAvYHxJXsXIyeHhICJxIlHbxghbDGJC/fWs3UxcnEICcxilJhwbgMzhPOVUeL3nbusIFVs AlYSE9tXgXWICGhKXP/7nRWkiFngB5PE9uMb2UASwgJ+EtdeNYKtYBFQlZh99jiYzSugJdHU eghskKiAl8SWfe1MIDangKnE6pdtYL1CAvES3yfcYoSoF5T4MfkeC4jNLCAvsW//VFYIW0ti /c7jTBMYge5EKJuFpGwWkrIFjMyrGCVSC5ILipPSc43yUsv1ihNzi0vz0vWS83M3MYJj9Zn0 DsbDu9wPMQpwMCrx8G74dDxCiDWxrLgy9xCjBAezkgjv5a9AId6UxMqq1KL8+KLSnNTiQ4ym QA9OZJYSTc4HppG8knhDE3MTc2MDC3NLSxMjJXHextnPwoUE0hNLUrNTUwtSi2D6mDg4pRoY 11fuMphh0RSYfj1zlvyU+dOjLvwSuppStnn985eG9nseP7kpktnW31l/7MOTJRsjV+/UTxOI KbnUoBx68tnxrf8cKrdOFTHb9b/5ljWb8gQlmU2L9d13HNfmsyvzTHSc2WnP/IvB4syqiesZ 73OuL9ZfUvBK/1C50Yzse5333Dy3Ov+wYOdfqcRSnJFoqMVcVJwIAI2POqHrAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170314140626epcas5p20694a5324299c556fbaf7df1e9bf5955 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170314140626epcas5p20694a5324299c556fbaf7df1e9bf5955 X-RootMTR: 20170314140626epcas5p20694a5324299c556fbaf7df1e9bf5955 References: <20170311213856.21701-1-krzk@kernel.org> <20170311213856.21701-3-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, March 11, 2017 11:38:55 PM Krzysztof Kozlowski wrote: > The Exynos Power Management Unit (PMU) drivers contain quite large > static arrays of register values necessary for given Exynos SoC to enter > low power mode. All this data is useless for ARMv8 SoC like > Exynos5433, because the image will not be shared between ARMv7 and > ARMv8. > > Add additional Kconfig symbol for selecting the SoC-specific driver > addons thus skipping the useless data in the final image (this is > similar approach to chosen for Exynos clock controller drivers): > - exynos-pmu driver will be compiled on both architectures ARMv7 > and ARMv8, > - additional driver_data for ARMv7 SoCs will not be built on ARMv8 > and a macro will return NULL for them in of_device_id - this should > be safe as these compatibles cannot match on ARMv7 and driver > anyway handles NULL driver_data, > - on ARMv8 compile only exynos-pmu driver which exposes the > syscon-regmap for PMU address space. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics