public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* sched_init prematurely enables interrupts
@ 2003-02-12 13:44 Todd Inglett
  2003-02-12 16:02 ` Robert Love
  0 siblings, 1 reply; 2+ messages in thread
From: Todd Inglett @ 2003-02-12 13:44 UTC (permalink / raw)
  To: linux-kernel

I think this bit is prematurely enabling interrupts in sched_init:

======== kernel/sched.c 1.1..1.156 ========
D 1.156 03/02/09 21:32:34-08:00 torvalds@home.transmeta.com 179 178 
32/24/2466
P kernel/sched.c
C Make "try_to_wake_up()" care about the state of the process woken up.
C
C This simplifies "default_wake_function()", and makes it possible for
C signal handling to wake up only stopped tasks without races.
C
C It also makes it impossible to wake up already running processes, which
C means that the early boot sequence has to use the (much more correct)
C "wake_up_forked_process()" to put the initial task on the runqueues.

The problem is that wake_up_forked_process() does an rq_unlock(rq) which 
is a spin_unlock_irq.

-todd


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: sched_init prematurely enables interrupts
  2003-02-12 13:44 sched_init prematurely enables interrupts Todd Inglett
@ 2003-02-12 16:02 ` Robert Love
  0 siblings, 0 replies; 2+ messages in thread
From: Robert Love @ 2003-02-12 16:02 UTC (permalink / raw)
  To: Todd Inglett; +Cc: linux-kernel

On Wed, 2003-02-12 at 08:44, Todd Inglett wrote:

> The problem is that wake_up_forked_process() does an rq_unlock(rq) which 
> is a spin_unlock_irq.

I believe this is fixed in Linus's bitkeeper.

	Robert Love


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-02-12 15:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-02-12 13:44 sched_init prematurely enables interrupts Todd Inglett
2003-02-12 16:02 ` Robert Love

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox