From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BADCC352A1 for ; Sun, 27 Nov 2022 21:29:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229606AbiK0V3y convert rfc822-to-8bit (ORCPT ); Sun, 27 Nov 2022 16:29:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbiK0V3v (ORCPT ); Sun, 27 Nov 2022 16:29:51 -0500 Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B21FA1B8; Sun, 27 Nov 2022 13:29:49 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 0FD126495E62; Sun, 27 Nov 2022 22:29:46 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id DOUHMhrDNvOa; Sun, 27 Nov 2022 22:29:45 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id ACF886495E7E; Sun, 27 Nov 2022 22:29:45 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id FYpMhiFZPMSA; Sun, 27 Nov 2022 22:29:45 +0100 (CET) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id 879AC6495E62; Sun, 27 Nov 2022 22:29:45 +0100 (CET) Date: Sun, 27 Nov 2022 22:29:45 +0100 (CET) From: Richard Weinberger To: Jeff Layton Cc: linux-nfs , linux-kernel , linux-fsdevel , chuck lever , anna , trond myklebust , Al Viro , raven , chris chilvers , david young , luis turcitu , david Message-ID: <1045320558.283423.1669584585412.JavaMail.zimbra@nod.at> In-Reply-To: <29d007755c6066552ac2a1b5bc498ce1ce28ab3b.camel@kernel.org> References: <20221117191151.14262-1-richard@nod.at> <20221117191151.14262-3-richard@nod.at> <1805608101.252119.1668719538854.JavaMail.zimbra@nod.at> <29d007755c6066552ac2a1b5bc498ce1ce28ab3b.camel@kernel.org> Subject: Re: [PATCH 2/3] fs: namei: Allow follow_down() to uncover auto mounts MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF97 (Linux)/8.8.12_GA_3809) Thread-Topic: namei: Allow follow_down() to uncover auto mounts Thread-Index: NMMtBM4gmoztCH6iGDr1qiHlAQw/TA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Ursprüngliche Mail ----- > Von: "Jeff Layton" >> So, in nfsd_cross_mnt() the follow_down() helper should use LOOKUP_AUTOMOUNT >> only >> if exp->ex_flags & NFSEXP_CROSSMOUNT is true? >> Sounds sane, thanks for the pointer. >> > > Yeah, I think so. I do wonder if we ought to make any provision for > "nohide" exports, but since you have to enumerate those explicitly, it > shouldn't be a huge problem for someone to just ensure that they're > mounted beforehand. TBH, I didn't invest much into the nohide feature wrt. NFS re-exporting. What problem do you have in mind? I wonder also what NFS client folks think about my changes before I send the next revision (with Jeff's comments addressed). Thanks, //richard