Re: [PATCH 06/18] thermal: exynos: fix trips limit checking in get_th_reg()

Daniel Lezcano
2018-04-30T15:34:37Z

On Thu, Apr 26, 2018 at 01:51:21PM +0200, Bartlomiej Zolnierkiewicz wrote:
> of_thermal_get_ntrips() may return value bigger than supported
> by a given SoC (i.e. on Exynos5422/5800)

Can you elaborate a bit ?

> so fix the code to not
> iterate the loop for i values >= data->ntrip.
>
> There should be no functional changes caused by this patch.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> drivers/thermal/samsung/exynos_tmu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index 5a64879..58cd68e 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -311,9 +311,9 @@ static u32 get_th_reg(struct exynos_tmu_data *data, u32 threshold, bool falling)
> const struct thermal_trip * const trips =
> of_thermal_get_trip_points(tz);
> unsigned long temp;
> - int i;
> + int i, ntrips = min_t(int, of_thermal_get_ntrips(tz), data->ntrip);
>
> - for (i = 0; i < of_thermal_get_ntrips(tz); i++) {
> + for (i = 0; i < ntrips; i++) {
> if (trips[i].type == THERMAL_TRIP_CRITICAL)
> continue;
>
> --
> 1.9.1
>

--

<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |