From: Ben Skeggs <bskeggs@redhat.com>
To: Dave Jones <davej@redhat.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, airlied@redhat.com
Subject: Re: nouveau: remove pointless assignment
Date: Wed, 18 Sep 2013 21:10:15 -0400 (EDT) [thread overview]
Message-ID: <1045388466.15024620.1379553015692.JavaMail.root@redhat.com> (raw)
In-Reply-To: <20130917212634.GA31390@redhat.com>
----- Original Message -----
> From: "Dave Jones" <davej@redhat.com>
> To: "Linux Kernel" <linux-kernel@vger.kernel.org>
> Cc: bskeggs@redhat.com, airlied@redhat.com
> Sent: Wednesday, 18 September, 2013 7:26:34 AM
> Subject: nouveau: remove pointless assignment
>
> self-assignment of a variable doesn't make a lot of sense.
Thanks, search-and-replace left-over, pulled into my tree.
Ben.
>
> Signed-off-by: Dave Jones <davej@fedoraproject.org>
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c
> b/drivers/gpu/drm/nouveau/nouveau_bo.c
> index 755c38d..d0a737c 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
> @@ -982,7 +982,7 @@ nouveau_bo_move_m2mf(struct ttm_buffer_object *bo, int
> evict, bool intr,
> bool no_wait_gpu, struct ttm_mem_reg *new_mem)
> {
> struct nouveau_drm *drm = nouveau_bdev(bo->bdev);
> - struct nouveau_channel *chan = chan = drm->ttm.chan;
> + struct nouveau_channel *chan = drm->ttm.chan;
> struct nouveau_bo *nvbo = nouveau_bo(bo);
> struct ttm_mem_reg *old_mem = &bo->mem;
> int ret;
>
next prev parent reply other threads:[~2013-09-19 1:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 21:26 nouveau: remove pointless assignment Dave Jones
2013-09-19 1:10 ` Ben Skeggs [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-07-25 17:35 Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1045388466.15024620.1379553015692.JavaMail.root@redhat.com \
--to=bskeggs@redhat.com \
--cc=airlied@redhat.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox