From: James Bottomley <James.Bottomley@steeleye.com>
To: Ion Badulescu <ionut@badula.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add new DMA_ADDR_T_SIZE define
Date: 19 Feb 2003 13:11:07 -0500 [thread overview]
Message-ID: <1045678275.2033.37.camel@mulgrave> (raw)
> 3. use run-time checks all over the place, of the
> "sizeof(dma_addr_t)==sizeof(u64)" kind, which adds unnecessary
> overhead to
> all platforms.
Actually, these aren't technically run time checks. Although the cpp
can't be used for sizeof(), the compiler (at least gcc) does seem to
have enough sense to optimise away if(..) branches it has enough
information to know won't be taken at compile time.
As long as this optimisation works, I think the if(sizeof(..)) checks
are fine for this.
James
next reply other threads:[~2003-02-19 18:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-19 18:11 James Bottomley [this message]
2003-02-19 18:20 ` [PATCH] add new DMA_ADDR_T_SIZE define Ion Badulescu
2003-02-19 22:07 ` David S. Miller
2003-02-19 22:41 ` Ion Badulescu
2003-02-19 22:29 ` David S. Miller
2003-02-19 22:53 ` Ion Badulescu
2003-02-19 22:38 ` David S. Miller
-- strict thread matches above, loose matches on Subject: below --
2003-02-23 7:02 Albert Cahalan
2003-02-23 7:00 ` David S. Miller
2003-02-23 7:20 ` Albert Cahalan
2003-02-19 16:26 Ion Badulescu
2003-02-19 17:20 ` Randy.Dunlap
2003-02-19 17:28 ` Ion Badulescu
2003-02-19 22:06 ` David S. Miller
2003-02-19 22:04 ` Ion Badulescu
2003-02-19 22:06 ` David S. Miller
2003-02-19 21:48 ` Jeff Garzik
2003-02-22 10:06 ` Ingo Oeser
2003-02-19 22:01 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1045678275.2033.37.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=ionut@badula.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox