Re: [PATCH] bonding: fix bond 6 mode change MAC of arp reply from vif to cause Domu's network unreachable intermittently

Cong Wang
2012-10-30T03:03:19Z

On Tue, 30 Oct 2012 at 02:47 GMT, Zheng Li <zheng.x.li@oracle.com> wrote:
> + struct slave *tmp_slave = NULL;
> + int i = 0, found_mac = 0;
> + bond_for_each_slave(bond, tmp_slave, i) {
> + if (ether_addr_equal_64bits(arp->mac_src,
> + tmp_slave->dev->dev_addr)) {
> + found_mac = 1;
> + break;
> + }
> + }
> + if (found_mac)
> + memcpy(arp->mac_src, tx_slave->dev->dev_addr,
> + ETH_ALEN);

A nitpick: found_mac can be a bool.