Re: Latest bk build error in xfrm.h

Rusty Lynch
2003-03-07T01:30:57Z

On Thu, 2003-03-06 at 16:03, David S. Miller wrote:
> From: Rusty Lynch <rusty@linux.co.intel.com>
> Date: 06 Mar 2003 13:38:44 -0800
>
> The problem is now the core networking has a dependency on the crypto
> hmac code (CONFIG_CRYOTPO_HMAC) since the ipv4 ipsec code was added to
> include/net/xfrm.h (which is included from all kinds of places.)
>
> The pretty much exhaust my networking/ipsec knowledge so no patch.
>
> I just pushed the following patch to Linus, should fix the build for
> everyone. It's also available at:
>
> bk://kernel.bkbits.net/davem/netfix-2.5
>
> Thanks.
>
> ChangeSet@1.1075.2.1, 2003-03-06 16:17:07-08:00, davem@nuts.ninka.net
> [IPSEC]: Fix build when ipsec is disabled.
>

There is still a build dependency between the INET_AH/INET_ESP and
CRYPTO_HMAC that the Kconfig does not cover. The following trivial
patch fixes it:

--- net/ipv4/Kconfig.orig 2003-03-06 17:36:13.000000000 -0800
+++ net/ipv4/Kconfig 2003-03-06 17:37:38.000000000 -0800
@@ -350,6 +350,7 @@

config INET_AH
tristate "IP: AH transformation"
+ depends on CRYPTO_HMAC
---help---
Support for IPsec AH.

@@ -357,6 +358,7 @@

config INET_ESP
tristate "IP: ESP transformation"
+ depends on CRYPTO_HMAC
---help---
Support for IPsec ESP.