Re: share COMPATIBLE_IOCTL()s across architectures

Pavel Machek
2003-03-20T19:25:15Z

Hi!

> > Why not simply move the common COMPATIBLE_IOCTLs and includes into
> > kernel/compat_ioctl.c or similar? That would IMHO be cleaner and
> > it does not need more preprocessing hacks.
> > There can still be a second init_sys32_ioctl() copy to handle the arch
> > specific list with additional translations.
>
> This would work for COMPATIBLE_IOCTLS, but the conversions handlers
> would need a new asm/ file for the macros. They're declared with assembler
> magic to avoid declaring all the functions. This way you need less files.

include/linux/compat_ioctl.h can be renamed to fs/compat_ioctl.c if
people prefer. I do not know which one is better.
Pavel

--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]