From: Peter Waechtler <pwaechtler@mac.com>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.5 patch] fix sound/oss/ics2101.c compilation
Date: 23 Mar 2003 19:11:03 +0100 [thread overview]
Message-ID: <1048443066.1936.2.camel@picklock> (raw)
In-Reply-To: <20030321201012.GO6940@fs.tum.de>
Am Fre, 2003-03-21 um 21.10 schrieb Adrian Bunk:
> The following patch fixes the problem for me, please check whether it's
> correct:
>
> --- linux-2.5.65-full/sound/oss/ics2101.c.old 2003-03-21 19:13:23.000000000 +0100
> +++ linux-2.5.65-full/sound/oss/ics2101.c 2003-03-21 19:13:53.000000000 +0100
> @@ -29,7 +29,7 @@
>
> extern int *gus_osp;
> extern int gus_base;
> -extern spinlock_t lock;
> +spinlock_t lock = SPIN_LOCK_UNLOCKED;
> static int volumes[ICS_MIXDEVS];
> static int left_fix[ICS_MIXDEVS] =
> {1, 1, 1, 2, 1, 2};
>
With that patch you do not protect anything.
The write_mix function should share the spinlock used in the
interrupt handler.
Do you compile for Uniprocessor? Can you post the relevant config?
I don't get a link error with SMP.
next prev parent reply other threads:[~2003-03-23 16:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-21 20:10 [2.5 patch] fix sound/oss/ics2101.c compilation Adrian Bunk
2003-03-23 18:11 ` Peter Waechtler [this message]
2003-03-30 9:30 ` Adrian Bunk
2003-03-31 0:04 ` Peter Waechtler
2003-03-31 10:05 ` Adrian Bunk
2003-03-31 12:14 ` [2.5 patch] typo fix for compilation Peter Waechtler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1048443066.1936.2.camel@picklock \
--to=pwaechtler@mac.com \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox