From: Martin Schlemmer <azarah@gentoo.org>
To: Greg KH <greg@kroah.com>
Cc: KML <linux-kernel@vger.kernel.org>,
Dominik Brodowski <linux@brodo.de>,
sensors@Stimpy.netroedge.com
Subject: Re: w83781d i2c driver updated for 2.5.66 (without sysfs support)
Date: 27 Mar 2003 01:34:32 +0200 [thread overview]
Message-ID: <1048721671.7569.46.camel@nosferatu.lan> (raw)
In-Reply-To: <20030326202904.GK24689@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
On Wed, 2003-03-26 at 22:29, Greg KH wrote:
> Some of the nasty casts should be fixed up though. Stuff like:
>
> > + ERROR7:
> > + if (!is_isa)
> > + i2c_detach_client(&
> > + (((struct w83781d_data
> > + *) (i2c_get_clientdata(new_client)))->
> > + lm75[1]));
> > + ERROR6:
> > + if (!is_isa)
> > + i2c_detach_client(&
> > + (((struct w83781d_data
> > + *) (i2c_get_clientdata(new_client)))->
> > + lm75[0]));
> > + ERROR5:
> > + if (!is_isa)
> > + kfree(((struct w83781d_data *) (i2c_get_clientdata(new_client)))->
> > + lm75);
>
> Is just obnoxious :)
>
Quick question .... With sysfs, is it not needed to call
i2c_detach_client ? I am asking this as it seems from patches
that you remove all these calls ...
Regards,
--
Martin Schlemmer
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2003-03-26 23:26 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-25 8:53 i2c driver changes for 2.5.66; adding w83781d support Martin Schlemmer
2003-03-25 17:56 ` Greg KH
2003-03-26 19:04 ` w83781d i2c driver updated for 2.5.66 (without sysfs support) Martin Schlemmer
2003-03-26 19:40 ` Jan Dittmer
2003-03-26 19:54 ` Martin Schlemmer
2003-03-26 20:26 ` Greg KH
2003-03-26 20:43 ` Christoph Hellwig
2003-03-26 21:23 ` Greg KH
2003-03-26 22:26 ` Mark Studebaker
2003-03-26 22:52 ` lm sensors sysfs file structure Greg KH
2003-03-27 10:46 ` Jan Dittmer
2003-03-27 10:50 ` Martin Schlemmer
2003-03-27 12:27 ` Jan Dittmer
2003-03-27 12:33 ` Martin Schlemmer
2003-03-27 13:05 ` Jan Dittmer
2003-03-27 13:31 ` Jean Delvare
2003-03-27 17:16 ` Mark M. Hoffman
2003-03-27 17:25 ` Greg KH
2003-03-27 18:06 ` Jan Dittmer
2003-03-27 18:13 ` Greg KH
2003-03-30 19:23 ` Pavel Machek
2003-04-01 6:44 ` Greg KH
2003-04-01 20:22 ` Pavel Machek
2003-04-01 23:27 ` Dave Jones
2003-04-03 0:28 ` Greg KH
2003-04-03 10:49 ` Dave Jones
2003-04-03 18:43 ` Dominik Brodowski
2003-03-27 18:40 ` Jan Dittmer
2003-03-27 18:52 ` Greg KH
2003-03-27 18:17 ` Patrick Mochel
2003-03-27 18:57 ` Jan Dittmer
2003-03-27 19:15 ` Martin Schlemmer
2003-03-27 19:25 ` Greg KH
2003-03-27 19:42 ` Greg KH
2003-03-27 20:32 ` Jan Dittmer
2003-03-27 21:53 ` Greg KH
2003-03-27 22:23 ` Mark M. Hoffman
2003-03-28 6:05 ` Martin Schlemmer
2003-03-28 18:34 ` Pavel Machek
2003-03-26 20:29 ` w83781d i2c driver updated for 2.5.66 (without sysfs support) Greg KH
2003-03-26 23:34 ` Martin Schlemmer [this message]
2003-03-26 23:46 ` Greg KH
2003-03-30 12:47 ` [PATCH-2.5] w83781d i2c driver updated for 2.5.66-bk4 (with sysfs support, empty tree) Martin Schlemmer
2003-04-02 22:22 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1048721671.7569.46.camel@nosferatu.lan \
--to=azarah@gentoo.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@brodo.de \
--cc=sensors@Stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox