From: Peter Waechtler <pwaechtler@mac.com>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [2.5 patch] typo fix for compilation
Date: 31 Mar 2003 14:14:05 +0200 [thread overview]
Message-ID: <1049112850.1873.1.camel@picklock> (raw)
In-Reply-To: <20030331100503.GD22827@fs.tum.de>
[-- Attachment #1: Type: text/plain, Size: 848 bytes --]
On Mon, 2003-03-31 at 12:05, Adrian Bunk wrote:
> On Mon, Mar 31, 2003 at 02:04:04AM +0200, Peter Waechtler wrote:
> >
> > There's a problem when compiling the GUS driver into the kernel
> > instead of as a module. I renamed the global "lock" to "gus_lock"
> > and made sure that it's used (shared by gus_midi, gus_wave, ics2101)
> >
> > [snippet of sound/oss/Makefile]
> > obj-$(CONFIG_SOUND_GUS) += gus.o ad1848.o
> > gus-objs := gus_card.o gus_midi.o gus_vol.o gus_wave.o ics2101.o
> >
> >
> > Adrian: Do you have a GUS and can test this?
>
> Unfortunately not, I noticed this problem while doing compile-only tests
> with a .config that has as much as possible enabled.
>
> BTW:
> The sound/oss/mad16.c part of your patch doesn't belong to this problem?
>
No. But there are more compile errors I've fixed while at it:
[-- Attachment #2: c.patch --]
[-- Type: text/plain, Size: 1746 bytes --]
diff -Nur -X dontdiff vanilla-2.5.66/drivers/char/ipmi/ipmi_devintf.c linux-2.5.66/drivers/char/ipmi/ipmi_devintf.c
--- vanilla-2.5.66/drivers/char/ipmi/ipmi_devintf.c 2003-03-26 19:53:59.000000000 +0100
+++ linux-2.5.66/drivers/char/ipmi/ipmi_devintf.c 2003-03-30 22:26:10.000000000 +0200
@@ -449,7 +449,7 @@
if (if_num > MAX_DEVICES)
return;
- snprinf(name, sizeof(name), "ipmidev/%d", if_num);
+ snprintf(name, sizeof(name), "ipmidev/%d", if_num);
handles[if_num] = devfs_register(NULL, name, DEVFS_FL_NONE,
ipmi_major, if_num,
diff -Nur -X dontdiff vanilla-2.5.66/drivers/net/tokenring/tms380tr.c linux-2.5.66/drivers/net/tokenring/tms380tr.c
--- vanilla-2.5.66/drivers/net/tokenring/tms380tr.c 2003-02-16 19:49:55.000000000 +0100
+++ linux-2.5.66/drivers/net/tokenring/tms380tr.c 2003-03-30 20:58:37.000000000 +0200
@@ -257,7 +257,7 @@
int err;
/* init the spinlock */
- spin_lock_init(tp->lock);
+ spin_lock_init(&tp->lock);
/* Reset the hardware here. Don't forget to set the station address. */
diff -Nur -X dontdiff vanilla-2.5.66/fs/cramfs/inode.c linux-2.5.66/fs/cramfs/inode.c
--- vanilla-2.5.66/fs/cramfs/inode.c 2003-03-26 19:54:05.000000000 +0100
+++ linux-2.5.66/fs/cramfs/inode.c 2003-03-30 18:31:42.000000000 +0200
@@ -51,7 +51,7 @@
inode->i_blocks = (cramfs_inode->size - 1) / 512 + 1;
inode->i_blksize = PAGE_CACHE_SIZE;
inode->i_gid = cramfs_inode->gid;
- inode->i_mtime = inode->i_atime = inode->i_ctime = 0;
+ inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME;
inode->i_ino = CRAMINO(cramfs_inode);
/* inode->i_nlink is left 1 - arguably wrong for directories,
but it's the best we can do without reading the directory
prev parent reply other threads:[~2003-03-31 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-21 20:10 [2.5 patch] fix sound/oss/ics2101.c compilation Adrian Bunk
2003-03-23 18:11 ` Peter Waechtler
2003-03-30 9:30 ` Adrian Bunk
2003-03-31 0:04 ` Peter Waechtler
2003-03-31 10:05 ` Adrian Bunk
2003-03-31 12:14 ` Peter Waechtler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1049112850.1873.1.camel@picklock \
--to=pwaechtler@mac.com \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox