From: Robert Love <rml@tech9.net>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] New cpu macro and i386 cleanup
Date: 04 Apr 2003 20:05:00 -0500 [thread overview]
Message-ID: <1049504699.753.128.camel@localhost> (raw)
In-Reply-To: <200304041931_MC3-1-3308-9B07@compuserve.com>
On Fri, 2003-04-04 at 19:29, Chuck Ebbert wrote:
> This annoyed me just enough to try and fix it. I'd
> fix all the rest but I know how annoyed people get at
> massive changes:
I like, although I am not hot on the name, but that is just taste.
One minor nit: it is not preempt-safe. But then again, neither is any
code that calls it without disabling preemption first. Maybe put a
comment above it like:
/*
* is_current_cpu() - are we running on the given processor?
*
* Note this is not preempt-safe: you need to explicitly
* disable preemption before calling this if you care
* about any consistency in the result
*/
The problem is not so much the call itself, but the use of the results.
Anywhere you care that 'cpu' is the current processor, kernel preemption
needs to remain disabled.
Robert Love
next prev parent reply other threads:[~2003-04-05 1:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-05 0:29 [PATCH] New cpu macro and i386 cleanup Chuck Ebbert
2003-04-05 1:05 ` Robert Love [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-04-05 10:24 Chuck Ebbert
2003-04-05 18:56 ` Robert Love
2003-04-05 22:17 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1049504699.753.128.camel@localhost \
--to=rml@tech9.net \
--cc=76306.1226@compuserve.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox