Re: Re: [PATCH][RESEND] socket interface for IPMI against 2.5.66-bk

Re: Re: [PATCH][RESEND] socket interface for IPMI against 2.5.66-bk

[Louis Zhuang]

On Fri, 2003-04-04 at 22:55, Corey Minyard wrote:
> I've merged this in, but I made some adjustments:
> 
>     * I added a copyright to include/net/ipmi.h (just copied from
> net/ipmi/af_ipmi.c)
Just curious, should we add copyright even when I have announced it by
'MODULE_LICENSE("GPL")'? I dislike too many leagal text in code...
>     * I added usage comments to include/net/ipmi.h
>     * I modified the ioctls to return EFAULT on a bad user address.
>     * I modified SIOCIPMIGETEVENT to take a pointer to an integer, not
> an integer.  That's the way ioctls work, they always take a pointer,
> even though it sucks, IMHO.
> 
> I also adapted it to the 2.4 kernel.
> 
> I'll put out an experimental patch for this sometime soon (with a bunch
> of other stuff).  I also have SMIC and full ACPI support as part of it,
> and I'm waiting for them.
> 
> - -Corey

-- 
Yours truly,
Louis Zhuang
---------------
My words are my own...

Fault Injection Test Harness Project
BK tree: http://fault-injection.bkbits.net/linux-2.5
Home Page: http://sf.net/projects/fault-injection

Open HPI Project
Home Page: http://sf.net/projects/openhpi

Re: [PATCH][RESEND] socket interface for IPMI against 2.5.66-bk

[Alan Cox]

> >Just curious, should we add copyright even when I have announced it by
> >'MODULE_LICENSE("GPL")'? I dislike too many leagal text in code...
> 
> I guess it's up to you, but you had added the header in all files but
> that one.

It is a good idea to do so (although its a matter of taste too). It
doesn't need a foot long pile of blurb. Its quite sufficient to say
Copyright (C) <year> <author) and state where the GPL is found.

Some people advise that the no warranty piece by present in each file
and you'll see IBM I think do that.

Re: [PATCH][RESEND] socket interface for IPMI against 2.5.66-bk

[Corey Minyard]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Louis Zhuang wrote:

>On Fri, 2003-04-04 at 22:55, Corey Minyard wrote:
>
>>I've merged this in, but I made some adjustments:
>>
>>    * I added a copyright to include/net/ipmi.h (just copied from
>>net/ipmi/af_ipmi.c)
>
>Just curious, should we add copyright even when I have announced it by
>'MODULE_LICENSE("GPL")'? I dislike too many leagal text in code...

I guess it's up to you, but you had added the header in all files but
that one.

Corey
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQE+kZa0IXnXXONXERcRAtd0AKCjBePfZPzdE+c9n/aBH0yqYI3SGwCdGZZc
GbHp0DsHLsa1yF/W/T7kYRc=
=pg9e
-----END PGP SIGNATURE-----