From: Martin Schlemmer <azarah@gentoo.org>
To: Greg KH <greg@kroah.com>
Cc: KML <linux-kernel@vger.kernel.org>, sensors@Stimpy.netroedge.com
Subject: Re: [PATCH-2.5] Fix w83781d sensor to use Milli-Volt for in_* in sysfs
Date: 08 Apr 2003 06:11:18 +0200 [thread overview]
Message-ID: <1049775078.23992.2.camel@nosferatu.lan> (raw)
In-Reply-To: <20030407215443.GA4386@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
On Mon, 2003-04-07 at 23:54, Greg KH wrote:
> On Mon, Apr 07, 2003 at 11:16:03PM +0200, Martin Schlemmer wrote:
> > --- drivers/i2c/chips/w83781d.c.orig 2003-04-07 22:53:37.000000000 +0200
> > +++ drivers/i2c/chips/w83781d.c 2003-04-07 22:53:34.000000000 +0200
> > @@ -364,7 +364,7 @@
> > \
> > w83781d_update_client(client); \
> > \
> > - return sprintf(buf,"%ld\n", (long)IN_FROM_REG(data->reg[nr] * 10)); \
> > + return sprintf(buf,"%ld\n", (long)IN_FROM_REG(data->reg[nr])); \
>
> Hm, this patch looks backwards, is it?
>
> Also, just as a side note, can you make your patches so that they can be
> applied with "patch -p1" instead of "patch -p0" which your current ones
> are? My tools treat -p1 patches much better :)
>
Yes, sorry, that is reverse. I have to go to work in a bit, so if you
need me to resend tonight, just ask.
--
Martin Schlemmer
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2003-04-08 4:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-07 21:16 [PATCH-2.5] Fix w83781d sensor to use Milli-Volt for in_* in sysfs Martin Schlemmer
2003-04-07 21:54 ` Greg KH
2003-04-08 4:11 ` Martin Schlemmer [this message]
2003-04-08 22:04 ` Greg KH
2003-04-09 6:18 ` Martin Schlemmer
2003-04-09 7:41 ` Greg KH
2003-04-08 22:11 ` Martin Schlemmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1049775078.23992.2.camel@nosferatu.lan \
--to=azarah@gentoo.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@Stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox