From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262811AbTDIGKm (for ); Wed, 9 Apr 2003 02:10:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262837AbTDIGKm (for ); Wed, 9 Apr 2003 02:10:42 -0400 Received: from [196.41.29.142] ([196.41.29.142]:24558 "EHLO workshop.saharact.lan") by vger.kernel.org with ESMTP id S262811AbTDIGKh (for ); Wed, 9 Apr 2003 02:10:37 -0400 Subject: Re: [PATCH-2.5] Fix w83781d sensor to use Milli-Volt for in_* in sysfs From: Martin Schlemmer To: Greg KH Cc: KML , sensors@Stimpy.netroedge.com In-Reply-To: <20030408220444.GA6674@kroah.com> References: <1049750163.4174.35.camel@nosferatu.lan> <20030407215443.GA4386@kroah.com> <1049775078.23992.2.camel@nosferatu.lan> <20030408220444.GA6674@kroah.com> Content-Type: text/plain Organization: Message-Id: <1049869101.2754.31.camel@workshop.saharact.lan> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.3- Date: 09 Apr 2003 08:18:21 +0200 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2003-04-09 at 00:04, Greg KH wrote: > Oh, I'm getting the following warning when building the driver, want to > look into this? > > drivers/i2c/chips/w83781d.c: In function `store_fan_div_reg': > drivers/i2c/chips/w83781d.c:715: warning: `old3' might be used uninitialized in this function > It is because old3 is only referenced if: ((data->type != w83781d) && data->type != as99127f) as those two chips don't have extended divisor bits ... It is however set in the first occurrence: --------------------------------------------------------------------- /* w83781d and as99127f don't have extended divisor bits */ if ((data->type != w83781d) && data->type != as99127f) { old3 = w83781d_read_value(client, W83781D_REG_VBAT); } --------------------------------------------------------------------- and thus is rather gcc being brain dead for not being able to figure old3 is only used within a if block like that. I was not sure about style policy in a case like this, so I left it as is, it should however be possible to 'fix' it with: --- 1/drivers/i2c/chips/w83781d.c 2003-04-09 08:16:08.000000000 +0200 +++ 2/drivers/i2c/chips/w83781d.c 2003-04-09 08:16:22.000000000 +0200 @@ -712,7 +712,7 @@ { struct i2c_client *client = to_i2c_client(dev); struct w83781d_data *data = i2c_get_clientdata(client); - u32 val, old, old2, old3; + u32 val, old, old2, old3 = 0; val = simple_strtoul(buf, NULL, 10); old = w83781d_read_value(client, W83781D_REG_VID_FANDIV); Regards, -- Martin Schlemmer