public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Love <rml@tech9.net>
To: Joe Korty <joe.korty@ccur.com>
Cc: Andrew Morton <akpm@digeo.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC] 2.5 TASK_INTERRUPTIBLE preemption race
Date: 14 Apr 2003 18:30:57 -0400	[thread overview]
Message-ID: <1050359457.3664.106.camel@localhost> (raw)
In-Reply-To: <20030414222750.GA19050@rudolph.ccur.com>

On Mon, 2003-04-14 at 18:27, Joe Korty wrote:

> I see.  It is because the 'goto pick_next_task' skips the
> 'deactivate_task' call.  Therefore the previous task remains on the
> run queue in spite of its TASK_UNINTERRUPTIBLE state.  Clever!

Yep :)

We actually did away with it for a bit in mid 2.5... it turned out to
not be worth it.  Its a little odd to use the flag like that, but its
quite simply and the results are good.

Means we can safely schedule anytime, no matter the state.  There are
tons of other places where we would not want to sleep if it were not for
PREEMPT_ACTIVE.

	Robert Love


      reply	other threads:[~2003-04-14 22:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-14 21:54 [RFC] 2.5 TASK_INTERRUPTIBLE preemption race Joe Korty
2003-04-14 22:00 ` Robert Love
2003-04-14 22:27   ` Joe Korty
2003-04-14 22:30     ` Robert Love [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1050359457.3664.106.camel@localhost \
    --to=rml@tech9.net \
    --cc=akpm@digeo.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=joe.korty@ccur.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox