From: Nigel Cunningham <ncunningham@clear.net.nz>
To: Patrick Mochel <mochel@osdl.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: New Software Suspend Patch for testing.
Date: Wed, 16 Apr 2003 09:33:32 +1200 [thread overview]
Message-ID: <1050442411.2983.5.camel@laptop-linux.cunninghams> (raw)
In-Reply-To: <Pine.LNX.4.44.0304151246400.912-100000@cherise>
Hi.
On Wed, 2003-04-16 at 08:06, Patrick Mochel wrote:
> I have a (fairly large) request:
>
> Would you mind updating Documentation/swsusp.txt (and moving it to
> Documentation/power/swsusp.txt)?
Okay. I've been meaning to update it.
>
> Frankly, the code is a mess and difficult to follow. It's also poorly
> commented. I spent the time about a month ago unwinding and deciphering
> it. Unfortunately, my work conflicts heavily with the work that you're
> doing, and the lack of documentation describing the intent of the code
> makes it difficult to make sane judgements of it.
One more problem is that you're also trying to follow a moving target
:>. In response to Pavel's last request, I'm preparing to work toward
using a linked list for the meta information (to allow unlimited image
size), and at the request of others, compressing (zlib) the saved pages
to make the image faster to save/load.
As to the layout and documentation, I hate them too. I had to keep
things as similar as possible to existing code to make merging easier,
but now that I'm merged with the 2.4 code, perhaps I can do some
cleanups.
Regards,
Nigel
next prev parent reply other threads:[~2003-04-15 21:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-04 11:12 New Software Suspend Patch for testing Nigel Cunningham
2003-04-04 13:30 ` Pavel Machek
2003-04-04 20:00 ` Nigel Cunningham
2003-04-04 23:03 ` Pavel Machek
2003-04-05 16:58 ` Alan Cox
2003-04-04 23:00 ` Pavel Machek
2003-04-15 20:06 ` Patrick Mochel
2003-04-15 21:33 ` Nigel Cunningham [this message]
2003-04-15 21:35 ` Patrick Mochel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1050442411.2983.5.camel@laptop-linux.cunninghams \
--to=ncunningham@clear.net.nz \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox