From: Greg KH <greg@kroah.com>
To: linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] More USB fixes for 2.5.67
Date: Wed, 16 Apr 2003 23:05:04 -0700 [thread overview]
Message-ID: <10505595041530@kroah.com> (raw)
In-Reply-To: <10505595042845@kroah.com>
ChangeSet 1.1062, 2003/04/14 10:25:40-07:00, henning@meier-geinitz.de
[PATCH] USB scanner.c endpoint detection fix
This patch fixes the endpoint numbers. They were numbered from 1 to n
but that assumption is not correct in all cases.
diff -Nru a/drivers/usb/image/scanner.c b/drivers/usb/image/scanner.c
--- a/drivers/usb/image/scanner.c Wed Apr 16 10:48:55 2003
+++ b/drivers/usb/image/scanner.c Wed Apr 16 10:48:55 2003
@@ -355,6 +355,10 @@
* is closed and disconnected. Avoids crashes when writing to a
* disconnected device. (Thanks to Greg KH).
*
+ * 0.4.12 2003-04-11
+ * - Fixed endpoint detection. The endpoints were numbered from 1 to n but
+ * that assumption is not correct in all cases.
+ *
* TODO
* - Performance
* - Select/poll methods
@@ -957,7 +961,7 @@
info ("probe_scanner: ignoring additional bulk_in_ep:%d", ep_cnt);
continue;
}
- have_bulk_in = ep_cnt;
+ have_bulk_in = endpoint->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK;
dbg("probe_scanner: bulk_in_ep:%d", have_bulk_in);
continue;
}
@@ -968,7 +972,7 @@
info ("probe_scanner: ignoring additional bulk_out_ep:%d", ep_cnt);
continue;
}
- have_bulk_out = ep_cnt;
+ have_bulk_out = endpoint->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK;
dbg("probe_scanner: bulk_out_ep:%d", have_bulk_out);
continue;
}
@@ -979,7 +983,7 @@
info ("probe_scanner: ignoring additional intr_ep:%d", ep_cnt);
continue;
}
- have_intr = ep_cnt;
+ have_intr = endpoint->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK;
dbg("probe_scanner: intr_ep:%d", have_intr);
continue;
}
next prev parent reply other threads:[~2003-04-17 5:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-17 6:03 [BK PATCH] More USB fixes for 2.5.67 Greg KH
2003-04-17 6:05 ` [PATCH] " Greg KH
2003-04-17 6:05 ` Greg KH
2003-04-17 6:05 ` Greg KH
2003-04-17 6:05 ` Greg KH
2003-04-17 6:05 ` Greg KH
2003-04-17 6:05 ` Greg KH
2003-04-17 6:05 ` Greg KH
2003-04-17 6:05 ` Greg KH [this message]
2003-04-17 6:05 ` Greg KH
2003-04-17 6:05 ` Greg KH
2003-04-17 6:05 ` Greg KH
2003-04-17 6:05 ` Greg KH
2003-04-17 6:05 ` Greg KH
2003-04-17 15:18 ` Matthew Dharm
2003-04-17 17:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10505595041530@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox