From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261845AbTDUSfb (ORCPT ); Mon, 21 Apr 2003 14:35:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261851AbTDUSfa (ORCPT ); Mon, 21 Apr 2003 14:35:30 -0400 Received: from pointblue.com.pl ([62.89.73.6]:37383 "EHLO pointblue.com.pl") by vger.kernel.org with ESMTP id S261845AbTDUSet (ORCPT ); Mon, 21 Apr 2003 14:34:49 -0400 Subject: small patch - 2.4.21-pre7 net/core/bk From: Grzegorz Jaskiewicz To: lkml Content-Type: text/plain Organization: K4 labs Message-Id: <1050950810.2738.10.camel@flat41> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.4 Date: 21 Apr 2003 19:46:50 +0100 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Maybe i just don't understeand this part of code, but i think we should not give calling driver five chances :) --------------------------------------------------------------- --- net/core/skbuff.c 2003-04-21 19:43:10.000000000 +0100 +++ net/core/skbuff.c.org 2003-04-21 19:42:35.000000000 +0100 @@ -167,9 +167,13 @@ u8 *data; if (in_interrupt() && (gfp_mask & __GFP_WAIT)) { - printk(KERN_ERR "alloc_skb called nonatomically " - "from interrupt %p\n", NET_CALLER(size)); - BUG(); + static int count = 0; + if (++count < 5) { + printk(KERN_ERR "alloc_skb called nonatomically " + "from interrupt %p\n", NET_CALLER(size)); + BUG(); + } + gfp_mask &= ~__GFP_WAIT; } /* Get the HEAD */ --------------------------------------------------------------- Also, i am bit confused with this part : /* Get the DATA. Size must match skb_add_mtu(). */ size = SKB_DATA_ALIGN(size); data = kmalloc(size + sizeof(struct skb_shared_info), gfp_mask); if (data == NULL) goto nodata; /* XXX: does not include slab overhead */ skb->truesize = size + sizeof(struct sk_buff); can anybody explain me please why skb->truesize gets size+sizeof(struct sk_buff) (acording to XXX above it, it is incorrect). -- Grzegorz Jaskiewicz aka Kain/K4 K4 labs