public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jens Axboe <axboe@suse.de>
Cc: Alexander Atanasov <alex@ssi.bg>,
	linux-kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC/PATCH] IDE Power Management try 1
Date: 25 Apr 2003 13:52:18 +0200	[thread overview]
Message-ID: <1051271538.15078.27.camel@gaston> (raw)
In-Reply-To: <20030425114932.GL1012@suse.de>


> If you add REQ_DRIVE_INTERNAL, and kill the other ones I mentioned, fine
> with me then.
> 
> 	rq->flags & REQ_DRIVE_INTERNAL
> 		rq->cmd[0] == PM
> 			pm stuf
> 		rq->cmd[0] = taskfile
> 			taskfile
> 
> etc. Make sense?

As I just wrote, I'd rather go the whole way then and break up flags
(which is a very bad name btw) into req_type & req_subtype, though
that would mean a bit of driver fixing....

Ben.


  reply	other threads:[~2003-04-25 11:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-24 12:59 [RFC/PATCH] IDE Power Management try 1 Benjamin Herrenschmidt
2003-04-25  9:35 ` Alexander Atanasov
2003-04-25 10:33   ` Jens Axboe
2003-04-25 11:50     ` Benjamin Herrenschmidt
2003-04-25 12:04     ` Bartlomiej Zolnierkiewicz
2003-04-25 11:32   ` Benjamin Herrenschmidt
2003-04-25 11:49     ` Jens Axboe
2003-04-25 11:52       ` Benjamin Herrenschmidt [this message]
2003-04-25 11:57         ` Benjamin Herrenschmidt
2003-04-25 12:13           ` Bartlomiej Zolnierkiewicz
2003-04-25 12:47             ` Benjamin Herrenschmidt
2003-04-25 12:16         ` Bartlomiej Zolnierkiewicz
2003-04-25 12:47           ` Benjamin Herrenschmidt
2003-04-25 13:58           ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1051271538.15078.27.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=alex@ssi.bg \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox