Re: Fix SWSUSP & !SWAP

Andrew Morton
2003-04-24T11:23:36Z

Nigel Cunningham <ncunningham@clear.net.nz> wrote:
>
> On Thu, 2003-04-24 at 21:46, Andrew Morton wrote:
> > > > Sorry, I still don't get it. Go through the steps for me:
> > > >
> > > > 1) suspend writes pages to disk
> > > >
> > > > 2) machine is shutdown
> > > >
> > > > 3) restart, journal replay
>
> Corruption comes here. The journal reply tidies things up that shouldn't
> be tidied up. They shouldn't be tidied up because once we reload the
> image, things should be in the same state as prior to suspend. If replay
> frees a block (thinking it wasn't properly linked or something similar),
> it introduces corruption.

No, this will not happen. All swapfile blocks must be allocated by swapon
time. It is just a chunk of disk and replay will not touch it.

That's for ext3, and no other filesystems journal data anyway...