From: John Levon <levon@movementarian.org>
To: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: [PATCH 3/8] OProfile update
Date: Sun, 4 May 2003 00:44:06 +0100 [thread overview]
Message-ID: <10520054461823@movementarian.org> (raw)
In-Reply-To: <1052005446607@movementarian.org>
Clear up the code around start_sem so it's more obvious, and remove a pointless
down/up pair on buffer_sem (shutdown is already synchronised in sync_stop()).
diff -Naur -X dontdiff linux-cvs/drivers/oprofile/oprof.c linux-me/drivers/oprofile/oprof.c
--- linux/drivers/oprofile/oprof.c 2003-04-30 19:58:07.000000000 +0100
+++ linux-me/drivers/oprofile/oprof.c 2003-04-29 01:16:00.000000000 +0100
@@ -28,6 +28,8 @@
{
int err;
+ down(&start_sem);
+
if ((err = alloc_cpu_buffers()))
goto out;
@@ -45,7 +47,6 @@
if ((err = sync_start()))
goto out3;
- down(&start_sem);
is_setup = 1;
up(&start_sem);
return 0;
@@ -58,6 +59,7 @@
out1:
free_cpu_buffers();
out:
+ up(&start_sem);
return err;
}
@@ -106,22 +108,20 @@
void oprofile_shutdown(void)
{
+ down(&start_sem);
sync_stop();
if (oprofile_ops->shutdown)
oprofile_ops->shutdown();
- /* down() is also necessary to synchronise all pending events
- * before freeing */
- down(&buffer_sem);
is_setup = 0;
- up(&buffer_sem);
free_event_buffer();
free_cpu_buffers();
+ up(&start_sem);
}
-
+
extern void timer_init(struct oprofile_operations ** ops);
-
+
static int __init oprofile_init(void)
{
int err;
next prev parent reply other threads:[~2003-05-03 23:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-03 23:44 [PATCH 1/8] OProfile update John Levon
2003-05-03 23:44 ` [PATCH 2/8] " John Levon
2003-05-03 23:44 ` John Levon [this message]
2003-05-03 23:44 ` [PATCH 4/8] " John Levon
2003-05-03 23:44 ` [PATCH 5/8] " John Levon
2003-05-03 23:44 ` [PATCH 6/8] " John Levon
2003-05-03 23:44 ` [PATCH 7/8] " John Levon
2003-05-03 23:44 ` [PATCH 8/8] " John Levon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10520054461823@movementarian.org \
--to=levon@movementarian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox