Re: test10-pre7

John Alvord
2000-10-31T21:02:59Z

On Tue, 31 Oct 2000 05:59:59 -0600, Peter Samuelson
<peter@cadcamlab.org> wrote:

>
>[Linus]
>> In short, we should _remove_ all traces of stuff like
>>
>> O_OBJS = $(filter-out $(export-objs), $(obj-y))
>>
>> It's wrong.
>>
>> We should just have
>>
>> O_OBJS = $(obj-y)
>>
>> which is always right.
>
>This part I agree with..
>
>> And it should make all this FIRST/LAST object file mockery a total
>> non-issue, because the whole concept turns out to be completely
>> unnecessary.
>>
>> Is there anything that makes this more complex than what I've
>> outlined above?
>
>One thing. The main benefit of $(sort), which I haven't heard you
>address yet, is to remove duplicate files. Think about 8390.o, and how
>many net drivers require it. There are two ways to handle this:
>
> obj-$(CONFIG_WD80x3) += wd.o 8390.o
> obj-$(CONFIG_EL2) += 3c503.o 8390.o
> obj-$(CONFIG_NE2000) += ne.o 8390.o
> obj-$(CONFIG_NE2_MCA) += ne2.o 8390.o
> obj-$(CONFIG_HPLAN) += hp.o 8390.o
>
You can avoid duplicates with
obj-$(CONFIG_WD80x3) += wd.o
ifneq (,$(findstring 8390.o,obj-$(CONFIG_WD80x3))
obj-$(CONFIG_WD80x3) += 8390.o
endif

Which is wordy but accomplishes the objective of avoiding duplicates.

john alvord