From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] TTY changes for 2.5.69
Date: Wed, 7 May 2003 16:16:27 -0700 [thread overview]
Message-ID: <10523493872313@kroah.com> (raw)
In-Reply-To: <1052349387898@kroah.com>
ChangeSet 1.1103, 2003/05/07 15:00:22-07:00, hannal@us.ibm.com
[PATCH] istallion tty_driver add .owner field remove MOD_INC/DEC_USE_COUNT
drivers/char/istallion.c | 10 ++--------
1 files changed, 2 insertions(+), 8 deletions(-)
diff -Nru a/drivers/char/istallion.c b/drivers/char/istallion.c
--- a/drivers/char/istallion.c Wed May 7 16:00:56 2003
+++ b/drivers/char/istallion.c Wed May 7 16:00:56 2003
@@ -1054,7 +1054,6 @@
if (portp->devnr < 1)
return(-ENODEV);
- MOD_INC_USE_COUNT;
/*
* Check if this port is in the middle of closing. If so then wait
@@ -1170,14 +1169,12 @@
save_flags(flags);
cli();
if (tty_hung_up_p(filp)) {
- MOD_DEC_USE_COUNT;
restore_flags(flags);
return;
}
if ((tty->count == 1) && (portp->refcount != 1))
portp->refcount = 1;
if (portp->refcount-- > 1) {
- MOD_DEC_USE_COUNT;
restore_flags(flags);
return;
}
@@ -1232,7 +1229,6 @@
portp->flags &= ~(ASYNC_CALLOUT_ACTIVE | ASYNC_NORMAL_ACTIVE |
ASYNC_CLOSING);
wake_up_interruptible(&portp->close_wait);
- MOD_DEC_USE_COUNT;
restore_flags(flags);
}
@@ -2369,7 +2365,6 @@
tty_hangup(portp->tty);
}
}
- MOD_DEC_USE_COUNT;
}
/*****************************************************************************/
@@ -3004,9 +2999,7 @@
if (! ((portp->flags & ASYNC_CALLOUT_ACTIVE) &&
(portp->flags & ASYNC_CALLOUT_NOHUP))) {
if (tty != (struct tty_struct *) NULL) {
- MOD_INC_USE_COUNT;
- if (schedule_task(&portp->tqhangup) == 0)
- MOD_DEC_USE_COUNT;
+ schedule_task(&portp->tqhangup);
}
}
}
@@ -5350,6 +5343,7 @@
*/
memset(&stli_serial, 0, sizeof(struct tty_driver));
stli_serial.magic = TTY_DRIVER_MAGIC;
+ stli_serial.owner = THIS_MODULE;
stli_serial.driver_name = stli_drvname;
stli_serial.name = stli_serialname;
stli_serial.major = STL_SERIALMAJOR;
next prev parent reply other threads:[~2003-05-07 23:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-07 23:15 [BK PATCH] TTY changes for 2.5.69 Greg KH
2003-05-07 23:16 ` [PATCH] " Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH [this message]
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
2003-05-07 23:16 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10523493872313@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox