Re: Question about style when converting from K&R to ANSI C.

Larry McVoy
2003-06-01T16:39:34Z

> Thanks for the input. You've convinced me. When going through
> arch/ppc/xmon/xmon.c, I will leave things like the following unchanged:
>
> /* Command interpreting routine */
> static int
> cmds(struct pt_regs *excp)
> {

Great.

> My changes will be similar to the following:
>
> @@ -1837,9 +1818,7 @@
> return *lineptr++;
> }
>
> -void
> -take_input(str)
> -char *str;
> +void take_input(char *str)
> {
> lineptr = str;
> }

OK, I'm confused. You said you were convinced but then shouldn't that be

void
take_input(char *str)
{
lineptr = str;
}

??
--
---
Larry McVoy lm at bitmover.com http://www.bitmover.com/lm