Re: [PATCH][2.5] Honour dont_enable_local_apic flag

["Brian J. Murrell" <brian@interlinx.bc.ca>]

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

On Sun, 2003-06-01 at 07:23, mikpe@csd.uu.se wrote:
> 
>    (And if its local APIC is broken, cpu_has_apic should be cleared
>    rather than setting the dont_enable flag. Post-boot code may
>    access the local APIC if CONFIG_X86_LOCAL_APIC && cpu_has_apic.)

So would you prefer something more along the lines of:

--- arch/i386/kernel/setup.c.orig       2003-04-26 10:34:35.000000000 -0400
+++ arch/i386/kernel/setup.c    2003-06-01 13:11:47.000000000 -0400
@@ -845,6 +845,10 @@
                 */
                else if (!memcmp(from, "highmem=", 8))
                        highmem_pages = memparse(from+8, &from) >> PAGE_SHIFT;
+               else if (!memcmp(from, "nolapic", 7)) {
+                               clear_bit(X86_FEATURE_APIC, &boot_cpu_data.x86_capability);
+                               set_bit(X86_FEATURE_APIC, &disabled_x86_caps);
+               }
 nextchar:
                c = *(from++);
                if (!c)

b.

-- 
Brian J. Murrell <brian@interlinx.bc.ca>

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]