public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg KH <greg@kroah.com>, Patrick Mochel <mochel@osdl.org>,
	Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: Flaw in the driver-model implementation of attributes
Date: 15 Jun 2003 10:40:45 -0700	[thread overview]
Message-ID: <1055698845.1351.44.camel@ixodes.goop.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0306151221190.32270-100000@netrider.rowland.org>

On Sun, 2003-06-15 at 09:42, Alan Stern wrote:
> If you're already aware of this, please forgive the intrusion.
> 
> There's a general problem in the driver model's implementation of 
> attribute files, in connection with loadable kernel modules.  The 
> sysfs_ops structure stores function pointers with no means for identifying 
> the module that contains the corresponding code.  As a result, it's 
> possible to call through one of these pointers even after the module has 
> been unloaded, causing an oops.
> 
> It's not hard to provoke this sort of situation.  A user process can
> open a sysfs device file, for instance, and delay trying to read it until 
> the module containing the device driver has been removed.  When the read 
> does occur, it runs into trouble.

I've seen this oops when a program has its cwd in a /sys directory
corresponding to a removed (or replaced) module.  I think active
references to a part of the /sys namespace corresponding to a module
should just pin the module.  But I haven't looked into it really.
	
	J


  reply	other threads:[~2003-06-15 17:27 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-15 16:42 Flaw in the driver-model implementation of attributes Alan Stern
2003-06-15 17:40 ` Jeremy Fitzhardinge [this message]
2003-06-16 14:05   ` Alan Stern
2003-06-16 17:08 ` Greg KH
2003-06-16 17:20   ` Russell King
2003-06-16 17:54     ` Alan Stern
2003-06-16 18:00       ` Patrick Mochel
2003-06-16 18:03       ` viro
2003-06-16 18:23         ` Alan Stern
2003-06-16 18:38           ` Patrick Mochel
2003-06-16 19:06             ` Alan Stern
2003-06-16 18:00     ` Martin Diehl
2003-06-16 18:15       ` viro
     [not found] <20030616194446.H13312@flint.arm.linux.org.uk>
2003-06-16 19:36 ` Alan Stern
2003-06-16 20:49   ` Patrick Mochel
2003-06-16 21:29     ` Alan Stern
2003-06-16 22:43       ` Patrick Mochel
2003-06-17 19:49         ` Alan Stern
2003-06-18  1:38           ` Kevin P. Fleming
2003-06-16 23:36       ` Greg KH
2003-06-17 17:29         ` Alan Stern
2003-06-17 17:33           ` Greg KH
2003-06-17 20:20             ` Alan Stern
  -- strict thread matches above, loose matches on Subject: below --
2003-06-18  3:44 Perez-Gonzalez, Inaky
2003-06-18  4:18 ` viro
2003-06-18  7:48 Perez-Gonzalez, Inaky
2003-06-18  8:12 ` viro
2003-06-18 14:32   ` Alan Stern
2003-06-18 17:15     ` Greg KH
2003-06-18 19:50       ` Alan Stern
2003-06-19 16:42         ` Patrick Mochel
2003-06-19 21:18           ` Alan Stern
2003-06-19 14:13       ` Alan Stern
2003-06-19 17:07         ` Patrick Mochel
2003-06-19 21:14           ` Alan Stern
2003-06-19 21:31             ` Greg KH
2003-06-20 14:22               ` Alan Stern
2003-06-20 18:32                 ` Greg KH
2003-07-02 22:12                   ` Greg KH
2003-07-03 14:51                     ` Alan Stern
2003-06-19 17:26         ` Mike Anderson
2003-06-18 19:52 Perez-Gonzalez, Inaky
2003-06-19  0:06 Clayton Weaver
2003-06-19  0:20 ` Kevin P. Fleming
2003-06-19 16:46   ` Patrick Mochel
2003-06-19 21:18 Perez-Gonzalez, Inaky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1055698845.1351.44.camel@ixodes.goop.org \
    --to=jeremy@goop.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochel@osdl.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox