From: Robert Love <rml@tech9.net>
To: Con Kolivas <kernel@kolivas.org>
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] 2.5.72 O(1) interactivity bugfix
Date: 18 Jun 2003 11:05:05 -0700 [thread overview]
Message-ID: <1055959503.7069.1864.camel@localhost> (raw)
In-Reply-To: <200306190043.14291.kernel@kolivas.org>
On Wed, 2003-06-18 at 07:43, Con Kolivas wrote:
> While messing with the interactivity code I found what appears to be an
> uninitialised variable (p->sleep_avg), which is responsible for all the
> boost/penalty in the scheduler.
The variable isn't uninitialized, it is inherited from the parent.
Recall that the task_struct of the new child starts off as a duplicate
of the parent's. If the variables are not explicitly set, they remain
the same as the parent's.
So this patch ends up resetting the sleep_avg to zero, instead of being
the same as the parent, which may or may not result in better
performance.
Robert Love
prev parent reply other threads:[~2003-06-18 17:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-18 14:43 [PATCH] 2.5.72 O(1) interactivity bugfix Con Kolivas
2003-06-18 17:59 ` Andreas Boman
2003-06-18 22:43 ` Con Kolivas
[not found] ` <1055977195.1077.41.camel@asgaard.midgaard.us>
2003-06-18 23:38 ` Con Kolivas
[not found] ` <1055983621.1753.23.camel@asgaard.midgaard.us>
2003-06-19 1:12 ` Con Kolivas
2003-06-19 2:00 ` Andreas Boman
2003-06-19 6:13 ` Mike Galbraith
2003-06-19 6:35 ` Con Kolivas
2003-06-19 8:11 ` Con Kolivas
2003-06-19 7:33 ` Nick Piggin
2003-06-19 8:51 ` Mike Galbraith
2003-06-19 8:57 ` Nick Piggin
2003-06-19 9:00 ` Nick Piggin
2003-06-19 9:18 ` Mike Galbraith
2003-06-18 18:05 ` Robert Love [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1055959503.7069.1864.camel@localhost \
--to=rml@tech9.net \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox