From: Robert Love <rml@tech9.net>
To: "J.A. Magallon" <jamagallon@able.es>
Cc: Lista Linux-Kernel <linux-kernel@vger.kernel.org>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
Andrew Morton <akpm@zip.com.au>
Subject: Re: [RFC][PATCH] CONFIG_NR_CPUS for 2.4.21
Date: 18 Jun 2003 18:04:34 -0700 [thread overview]
Message-ID: <1055984673.8770.9.camel@localhost> (raw)
In-Reply-To: <20030618230136.GG3768@werewolf.able.es>
On Wed, 2003-06-18 at 16:01, J.A. Magallon wrote:
> Oops, credits for this should go to (and possible comments/reject come
> from) Andrew Morton <akpm@zip.com.au>, Robert Love <rml@tech9.net>
It looks fine to me, although I do not think this is as critical an
issue as it was for 2.5, because the per-processor bloat is not nearly
as bad in 2.4 as 2.5. Nonetheless, this does not actually break
anything.
Except, I notice in some places (namely, 64-bit architectures), you set
the default NR_CPUS value to 64. While this ought to work if
sizeof(unsigned long)==8, it might not and is probably not a change we
want in a stable series. The default should be 32 all around.
Robert Love
next prev parent reply other threads:[~2003-06-19 0:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-18 22:23 [RFC][PATCH] CONFIG_NR_CPUS for 2.4.21 J.A. Magallon
2003-06-18 23:01 ` J.A. Magallon
2003-06-19 1:04 ` Robert Love [this message]
2003-06-20 17:14 ` Marcelo Tosatti
2003-06-20 20:43 ` [RFC][PATCH] CONFIG_NR_CPUS for 2.4.21 (take 2) J.A. Magallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1055984673.8770.9.camel@localhost \
--to=rml@tech9.net \
--cc=akpm@zip.com.au \
--cc=jamagallon@able.es \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox