From: Chris Mason <mason@suse.com>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] buffer_insert_list should use list_add_tail
Date: 19 Jun 2003 09:15:39 -0400 [thread overview]
Message-ID: <1056028538.6757.94.camel@tiny.suse.com> (raw)
Hello all,
buffer_insert_list puts buffers onto the head of bh->b_inode_buffers,
which means that on fsync we are writing things out in reverse order. I
think we either want this patch, or we want to walk the list in reverse
in fsync_buffers_list
(this has not been well tested, but I can't think of any problems it
would cause)
-chris
--- linux.marcelo/fs/buffer.c Thu Jun 19 09:09:28 2003
+++ linux/fs/buffer.c Thu Jun 19 09:04:17 2003
@@ -591,7 +604,7 @@
if (buffer_attached(bh))
list_del(&bh->b_inode_buffers);
set_buffer_attached(bh);
- list_add(&bh->b_inode_buffers, list);
+ list_add_tail(&bh->b_inode_buffers, list);
spin_unlock(&lru_list_lock);
}
next reply other threads:[~2003-06-19 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-19 13:15 Chris Mason [this message]
2003-06-19 23:11 ` [PATCH] buffer_insert_list should use list_add_tail Nathan Scott
2003-06-21 8:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1056028538.6757.94.camel@tiny.suse.com \
--to=mason@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox