public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vojtech Pavlik <vojtech@ucw.cz>
To: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: [PATCH 7/11] input: Fixes for the uinput userspace
Date: Sat, 21 Jun 2003 15:51:57 +0200	[thread overview]
Message-ID: <10562035172084@twilight.ucw.cz> (raw)
In-Reply-To: <10562035171778@twilight.ucw.cz>

You can pull this changeset from:
	bk://kernel.bkbits.net/vojtech/input

===================================================================

ChangeSet@1.1365, 2003-06-21 04:43:13-07:00, neilb@cse.unsw.edu.au
  input: Three fixes for the uinput userspace input device driver.


 uinput.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

===================================================================

diff -Nru a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
--- a/drivers/input/misc/uinput.c	Sat Jun 21 15:25:36 2003
+++ b/drivers/input/misc/uinput.c	Sat Jun 21 15:25:36 2003
@@ -49,11 +49,11 @@
 
 	udev = (struct uinput_device *)dev->private;
 
-	udev->head = (udev->head + 1) % UINPUT_BUFFER_SIZE;
 	udev->buff[udev->head].type = type;
 	udev->buff[udev->head].code = code;
 	udev->buff[udev->head].value = value;
 	do_gettimeofday(&udev->buff[udev->head].time);
+	udev->head = (udev->head + 1) % UINPUT_BUFFER_SIZE;
 
 	wake_up_interruptible(&udev->waitq);
 
@@ -82,6 +82,7 @@
 	udev->dev->event = uinput_dev_event;
 	udev->dev->upload_effect = uinput_dev_upload_effect;
 	udev->dev->erase_effect = uinput_dev_erase_effect;
+	udev->dev->private = udev;
 
 	init_waitqueue_head(&(udev->waitq));
 
@@ -264,7 +265,7 @@
 		return -ENODEV;
 
 	while ((udev->head != udev->tail) && 
-	    (retval + sizeof(struct uinput_device) <= count)) {
+	    (retval + sizeof(struct input_event) <= count)) {
 		if (copy_to_user(buffer + retval, &(udev->buff[udev->tail]),
 		    sizeof(struct input_event))) return -EFAULT;
 		udev->tail = (udev->tail + 1) % UINPUT_BUFFER_SIZE;


  reply	other threads:[~2003-06-21 13:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-21 13:51 [PATCH 1/11] input: HID devices can have the same logical max and min Vojtech Pavlik
2003-06-21 13:51 ` [PATCH 2/11] input: Fix misdetection of PS/2 mice as AT keyboards Vojtech Pavlik
2003-06-21 13:51   ` [PATCH 3/11] input: Add locking to serio.c Vojtech Pavlik
2003-06-21 13:51     ` [PATCH 4/11] input: Remove unused var from serio struct Vojtech Pavlik
2003-06-21 13:51       ` [PATCH 5/11] input: Gameport was never closed after calibrating Vojtech Pavlik
2003-06-21 13:51         ` [PATCH 6/11] input: Add Logitech MX PS2++ support Vojtech Pavlik
2003-06-21 13:51           ` Vojtech Pavlik [this message]
2003-06-21 13:51             ` [PATCH 8/11] input: Change order of search for beeper devices in keyboard.c Vojtech Pavlik
2003-06-21 13:51               ` [PATCH 9/11] input: Fix double kfree of device->rdesc in hid-core Vojtech Pavlik
2003-06-21 13:51                 ` [PATCH 10/11] input: Fixes for sidewinder.c Vojtech Pavlik
2003-06-21 13:51                   ` [PATCH 11/11] input: Make GC_PSX_DELAY lower and configurable Vojtech Pavlik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10562035172084@twilight.ucw.cz \
    --to=vojtech@ucw.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox