From: David Howells <dhowells@redhat.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] AFS: Add a function to excise a rejected write from the pagecache
Date: Wed, 30 May 2007 11:35:23 +0100 [thread overview]
Message-ID: <10564.1180521323@redhat.com> (raw)
In-Reply-To: <1180050860.8872.42.camel@heimdal.trondhjem.org>
Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> All I do is to protect new calls to read() and write() with a call to
> check if the page cache needs invalidating.
What about mmap()? What if someone gets a mapping on a section of file that
subsequently has a write rejected on it? If you invalidate only on
read()/write(), what do you do about such a mapping?
> That won't stop any existing append writes from punching ugly holes into the
> file, but trying to recover from that sort of thing would be _really_
> painful!
Definitely.
David
next prev parent reply other threads:[~2007-05-30 10:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-23 19:15 [PATCH 1/4] AFS: Add TestSetPageError() David Howells
2007-05-23 19:15 ` [PATCH 2/4] AFS: Add a function to excise a rejected write from the pagecache David Howells
2007-05-24 20:38 ` Andrew Morton
2007-05-24 21:35 ` David Howells
2007-05-24 21:47 ` Andrew Morton
2007-05-24 22:34 ` David Howells
2007-05-24 22:46 ` Andrew Morton
2007-05-24 23:08 ` David Howells
2007-05-24 23:24 ` Andrew Morton
2007-05-24 23:37 ` David Howells
2007-05-24 22:35 ` Trond Myklebust
2007-05-24 23:18 ` David Howells
2007-05-24 23:54 ` Trond Myklebust
2007-05-30 10:35 ` David Howells [this message]
2007-05-30 17:39 ` Trond Myklebust
2007-05-23 19:15 ` [PATCH 3/4] AFS: Improve handling of a rejected writeback David Howells
2007-05-23 19:15 ` [PATCH 4/4] AFS: Implement shared-writable mmap David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10564.1180521323@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox