From: Arjan van de Ven <arjanv@redhat.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Aleksey Gorelov <Aleksey_Gorelov@Phoenix.com>,
linux-kernel@vger.kernel.org, mj@ucw.cz, alan@redhat.com
Subject: Re: [PATCH] Re: VIA PCI IRQ router bug fix
Date: 04 Jul 2003 09:31:47 +0200 [thread overview]
Message-ID: <1057303907.5801.0.camel@laptop.fenrus.com> (raw)
In-Reply-To: <3F04C1AA.80107@pobox.com>
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
>
> static int pirq_via_set(struct pci_dev *router, struct pci_dev *dev, int pirq, int irq)
> {
> - write_config_nybble(router, 0x55, pirq, irq);
> + write_config_nybble(router, 0x55, pirq == 4 ? 5 : pirq, irq);
> return 1;
> }
you missed the
> + return (x >> 4);
in the original patch... so your code is NOT identical.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2003-07-04 7:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-03 19:19 VIA PCI IRQ router bug fix Aleksey Gorelov
2003-07-03 23:52 ` [PATCH] " Jeff Garzik
2003-07-04 7:31 ` Arjan van de Ven [this message]
2003-07-04 13:44 ` Jeff Garzik
2003-07-04 15:12 ` Davide Libenzi
-- strict thread matches above, loose matches on Subject: below --
2003-07-04 0:13 Aleksey Gorelov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1057303907.5801.0.camel@laptop.fenrus.com \
--to=arjanv@redhat.com \
--cc=Aleksey_Gorelov@Phoenix.com \
--cc=alan@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mj@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox