From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Mikael Pettersson <mikpe@csd.uu.se>,
Linus Torvalds <torvalds@transmeta.com>
Cc: Paul Mackerras <paulus@samba.org>,
linux-kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][2.5.74] fix IDE init oops on PowerMac
Date: 06 Jul 2003 21:28:47 +0200 [thread overview]
Message-ID: <1057519727.503.72.camel@gaston> (raw)
In-Reply-To: <200307040016.h640GV7o018321@harpo.it.uu.se>
On Fri, 2003-07-04 at 02:16, Mikael Pettersson wrote:
> Booting kernel 2.5.74 on a PowerMac with CONFIG_BLK_DEV_IDE_PMAC=y
> results in an oops during IDE init, and the box then reboots.
> .../...
>The patch below updates drivers/ide/ppc/pmac.c to also set up the
> hwif->ide_dma_queued_off and hwif->ide_dma_queued_on function
> pointers, which fixes the oops. Tested on my ancient PM4400.
Patch is fine, actually, it's already in my tree though my version
of this driver isn't merged yet as it depends on the other changes
to the "macio" driver model that I haven't pushed upstream so far.
Linus, can you apply please ?
Thanks,
Ben.
diff -ruN linux-2.5.74/drivers/ide/ppc/pmac.c
linux-2.5.74.ide-pmac-fixes/drivers/ide/ppc/pmac.c
--- linux-2.5.74/drivers/ide/ppc/pmac.c 2003-05-28 22:16:00.000000000
+0200
+++ linux-2.5.74.ide-pmac-fixes/drivers/ide/ppc/pmac.c 2003-07-04
00:45:05.000000000 +0200
@@ -1514,6 +1514,8 @@
ide_hwifs[ix].ide_dma_timeout = &__ide_dma_timeout;
ide_hwifs[ix].ide_dma_retune = &__ide_dma_retune;
ide_hwifs[ix].ide_dma_lostirq = &pmac_ide_dma_lostirq;
+ ide_hwifs[ix].ide_dma_queued_on = &__ide_dma_queued_on;
+ ide_hwifs[ix].ide_dma_queued_off = &__ide_dma_queued_off;
#ifdef CONFIG_BLK_DEV_IDEDMA_PMAC_AUTO
if (!noautodma)
next prev parent reply other threads:[~2003-07-06 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-04 0:16 [PATCH][2.5.74] fix IDE init oops on PowerMac Mikael Pettersson
2003-07-06 19:28 ` Benjamin Herrenschmidt [this message]
2003-07-07 6:53 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1057519727.503.72.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@csd.uu.se \
--cc=paulus@samba.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox