Re: [PATCH 1/3] Char: stallion, don't fail with less than max panels

Andrew Morton
2007-06-06T00:18:16Z

On Tue, 5 Jun 2007 23:20:57 +0200 (CEST)
Jiri Slaby <jirislaby@gmail.com> wrote:

> stallion, don't fail with less than max panels
>

Why not?

What problem is this patch fixing, and how does it fix it?

What are the consequences of not having this patch in the kernel?

etc. More complete changlogs, please.

>
> diff --git a/drivers/char/stallion.c b/drivers/char/stallion.c
> index e45113a..265abad 100644
> --- a/drivers/char/stallion.c
> +++ b/drivers/char/stallion.c
> @@ -2172,7 +2172,7 @@ static int __devinit stl_initech(struct stlbrd *brdp)
> }
> status = inb(ioaddr + ECH_PNLSTATUS);
> if ((status & ECH_PNLIDMASK) != nxtid)
> - goto err_fr;
> + break;
> panelp = kzalloc(sizeof(struct stlpanel), GFP_KERNEL);
> if (!panelp) {
> printk("STALLION: failed to allocate memory "