From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423161AbWCXGCF (ORCPT ); Fri, 24 Mar 2006 01:02:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1423159AbWCXGCF (ORCPT ); Fri, 24 Mar 2006 01:02:05 -0500 Received: from cantor2.suse.de ([195.135.220.15]:31130 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S1423152AbWCXGCC (ORCPT ); Fri, 24 Mar 2006 01:02:02 -0500 From: NeilBrown To: Andrew Morton Date: Fri, 24 Mar 2006 17:00:01 +1100 Message-Id: <1060324060001.2459@suse.de> X-face: [Gw_3E*Gng}4rRrKRYotwlE?.2|**#s9D Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org An md array can be asked to change the amount of each device that it is using, and in particular can be asked to use the maximum available space. This currently only works if the first device is not larger than the rest. As 'size' gets changed and so 'fit' becomes wrong. So check if a 'fit' is required early and don't corrupt it. Signed-off-by: Doug Ledford Signed-off-by: Neil Brown ### Diffstat output ./drivers/md/md.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff ./drivers/md/md.c~current~ ./drivers/md/md.c --- ./drivers/md/md.c~current~ 2006-03-24 14:01:30.000000000 +1100 +++ ./drivers/md/md.c 2006-03-24 14:06:49.000000000 +1100 @@ -3575,6 +3575,7 @@ static int update_size(mddev_t *mddev, u mdk_rdev_t * rdev; int rv; struct list_head *tmp; + int fit = (size == 0); if (mddev->pers->resize == NULL) return -EINVAL; @@ -3592,7 +3593,6 @@ static int update_size(mddev_t *mddev, u return -EBUSY; ITERATE_RDEV(mddev,rdev,tmp) { sector_t avail; - int fit = (size == 0); if (rdev->sb_offset > rdev->data_offset) avail = (rdev->sb_offset*2) - rdev->data_offset; else