public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vinay K Nallamothu <vinay-rc@naturesoft.net>
To: Maxim Krasnyansky <maxk@qualcomm.com>
Cc: LKML <linux-kernel@vger.kernel.org>, trivial@rustcorp.com.au
Subject: [PATCH 2.6.0-test3][BLUETOOTH] BUG fix for drivers/bluetooth/hci_usb.c
Date: 09 Aug 2003 18:41:59 +0530	[thread overview]
Message-ID: <1060434720.2511.45.camel@lima.royalchallenge.com> (raw)

Hi,

The patch below fixes two pointer reference bugs (shows up as compile
time warnings given below) which wrongly take the address of "struct
usb_interface*".

============compiler warning============================
drivers/bluetooth/hci_usb.c: In function `hci_usb_probe':
drivers/bluetooth/hci_usb.c:786: warning: assignment from incompatible
pointer type
drivers/bluetooth/hci_usb.c:810: warning: assignment from incompatible
pointer type
=========================================================================
diff -urN linux-2.6.0-test3/drivers/bluetooth/hci_usb.c linux-2.6.0-test3-nvk/drivers/bluetooth/hci_usb.c
--- linux-2.6.0-test3/drivers/bluetooth/hci_usb.c	2003-07-15 17:22:49.000000000 +0530
+++ linux-2.6.0-test3-nvk/drivers/bluetooth/hci_usb.c	2003-08-09 18:17:21.000000000 +0530
@@ -783,7 +783,7 @@
 
 	BT_DBG("udev %p ifnum %d", udev, ifnum);
 
-	iface = &udev->actconfig->interface[0];
+	iface = udev->actconfig->interface[0];
 
 	/* Check our black list */
 	if (usb_match_id(intf, ignore_ids))
@@ -807,7 +807,7 @@
 
 	ifn = min_t(unsigned int, udev->actconfig->desc.bNumInterfaces, HCI_MAX_IFACE_NUM);
 	for (i = 0; i < ifn; i++) {
-		iface = &udev->actconfig->interface[i];
+		iface = udev->actconfig->interface[i];
 		for (a = 0; a < iface->num_altsetting; a++) {
 			uif = &iface->altsetting[a];
 			for (e = 0; e < uif->desc.bNumEndpoints; e++) {




             reply	other threads:[~2003-08-09 12:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-09 13:11 Vinay K Nallamothu [this message]
2003-08-09 19:04 ` [PATCH 2.6.0-test3][BLUETOOTH] BUG fix for drivers/bluetooth/hci_usb.c Taneli Vähäkangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1060434720.2511.45.camel@lima.royalchallenge.com \
    --to=vinay-rc@naturesoft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxk@qualcomm.com \
    --cc=trivial@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox