Re: [RFC][PATCH] Make cryptoapi non-optional?

Matt Mackall
2003-08-17T04:28:49Z

On Sat, Aug 16, 2003 at 01:40:56PM -0700, Adam J. Richter wrote:
> At 2003-08-16 15:51:10, Matt Mackall wrote:
> >The
> >current code uses the stack (though currently rather a lot of it),
> >which lets it be fully re-entrant. Not an option with cryptoapi.
>
> I posted a patch a while ago on one of the linux crypto
> mailing lists that defined these routines to support allocating
> crypto_tfm's on the stack:
>
> int crypto_tfm_alloc_size(struct crypto_alg *alg, u32 tfm_flags);
> int crypto_tfm_init(struct crypto_tfm *tfm, struct crypto_alg *alg,
> u32 tfm_flags);
>
> The patch also created crypto_alg_{get,put} routines so that
> crypto_tfm's could be created quickly without having to look up and
> release references to crypto_alg's.

Indeed. I suggested pretty much the same thing earlier in this thread
and got shot down by davem.

--
Matt Mackall : http://www.selenic.com : of or relating to the moon