Re: [PATCH 7/9] convert drivers/scsi to virt_to_pageoff()

Christoph Hellwig
2003-08-10T14:54:16Z

On Sun, Aug 10, 2003 at 09:03:22PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@?(B wrote:
> BTW, drivers/scsi/3w-xxxx.c says:
>
> 1.02.00.029 - Add missing pci_free_consistent() in tw_allocate_memory().
> Replace pci_map_single() with pci_map_page() for highmem.
> Check for tw_setfeature() failure.
>
> Have problems in pci_map_single() with highmem already gone away?

pci_map_single can't support highmem, but the case you converted can't
be highmem either. There's other places in the driver where we get handed
scatterlists that can contain highmem pages and thus need to be handled
with pci_map_page or better with pci_map_sg.