virt_to_offset() (Re: [RFC][PATCH] Make cryptoapi non-optional?)

YOSHIFUJI Hideaki / 吉藤英明
2003-08-10T08:32:12Z

In article <20030810081529.GX31810@waste.org> (at Sun, 10 Aug 2003 03:15:29 -0500), Matt Mackall <mpm@selenic.com> says:

:
> + sg[0].page = virt_to_page(tmp);
> + sg[0].offset = ((long) tmp & ~PAGE_MASK);
> + sg[0].length = sizeof(tmp);

BTW, we spread ((long) ptr & ~PAGE_MASK); it seems ugly.
Why don't we have vert_to_offset(ptr) or something like this?
#define virt_to_offset(ptr) ((unsigned long) (ptr) & ~PAGE_MASK)
Is this bad idea?

--
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA