From: James Bottomley <James.Bottomley@steeleye.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: "David S. Miller" <davem@redhat.com>,
willy@debian.org, Linux Kernel <linux-kernel@vger.kernel.org>,
PARISC list <parisc-linux@lists.parisc-linux.org>,
drepper@redhat.com
Subject: Re: [parisc-linux] Re: Problems with kernel mmap (failing tst-mmap-eofsync in glibc on parisc)
Date: 23 Aug 2003 10:59:48 -0500 [thread overview]
Message-ID: <1061654391.1995.74.camel@mulgrave> (raw)
In-Reply-To: <Pine.LNX.4.44.0308230820020.3590-100000@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 415 bytes --]
On Sat, 2003-08-23 at 02:22, Hugh Dickins wrote:
> Good idea. It's VM_MAYSHARE you need to check for.
OK, to get all this to work, there's a corner case in do_mremap() that I
need to be fixed:
When choosing the flags for the new area, it keys off VM_SHARED to
determine whether MAP_SHARED is passed to the mapping. It has to key of
VM_MAYSHARE to preserve VM_MAYSHARE on the new mapping.
Patch below.
James
[-- Attachment #2: tmp.diff --]
[-- Type: text/plain, Size: 421 bytes --]
===== mremap.c 1.32 vs edited =====
--- 1.32/mm/mremap.c Thu Aug 7 12:29:10 2003
+++ edited/mremap.c Sat Aug 23 10:54:21 2003
@@ -420,7 +420,7 @@
if (flags & MREMAP_MAYMOVE) {
if (!(flags & MREMAP_FIXED)) {
unsigned long map_flags = 0;
- if (vma->vm_flags & VM_SHARED)
+ if (vma->vm_flags & VM_MAYSHARE)
map_flags |= MAP_SHARED;
new_addr = get_unmapped_area(vma->vm_file, 0, new_len,
next prev parent reply other threads:[~2003-08-23 17:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-22 14:40 Problems with kernel mmap (failing tst-mmap-eofsync in glibc on parisc) James Bottomley
2003-08-22 16:14 ` David S. Miller
2003-08-22 16:34 ` [parisc-linux] " Matthew Wilcox
2003-08-22 16:39 ` David S. Miller
2003-08-22 17:41 ` Matthew Wilcox
2003-08-22 17:36 ` David S. Miller
2003-08-22 18:01 ` David S. Miller
2003-08-22 18:34 ` Hugh Dickins
2003-08-22 18:31 ` David S. Miller
2003-08-22 18:56 ` James Bottomley
2003-08-22 19:19 ` David S. Miller
2003-08-22 22:27 ` James Bottomley
2003-08-22 22:41 ` David S. Miller
2003-08-23 1:09 ` James Bottomley
2003-08-23 7:22 ` Hugh Dickins
2003-08-23 15:59 ` James Bottomley [this message]
2003-08-23 21:44 ` David S. Miller
2003-08-23 21:43 ` David S. Miller
2003-08-23 22:21 ` James Bottomley
2003-08-23 22:51 ` David S. Miller
2003-08-23 23:01 ` James Bottomley
2003-08-23 22:53 ` David S. Miller
2003-08-23 23:11 ` James Bottomley
2003-08-24 0:22 ` David S. Miller
[not found] ` <1061702282.1992.1153.camel@mulgrave>
[not found] ` <20030823222300.4695a0c4.davem@redhat.com>
2003-08-24 16:54 ` James Bottomley
2003-08-22 18:41 ` James Bottomley
2003-08-22 19:02 ` Hugh Dickins
2003-08-22 19:09 ` Randolph Chung
2003-08-22 16:42 ` Russell King
2003-08-22 16:39 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1061654391.1995.74.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=davem@redhat.com \
--cc=drepper@redhat.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=parisc-linux@lists.parisc-linux.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox