public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: insecure@mail.od.ua
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>,
	linux-kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix ide unregister vs. driver model
Date: Mon, 25 Aug 2003 12:04:26 +0200	[thread overview]
Message-ID: <1061805866.779.51.camel@gaston> (raw)
In-Reply-To: <200308251301.00267.insecure@mail.od.ua>

On Mon, 2003-08-25 at 12:01, insecure wrote:
> On Sunday 24 August 2003 16:05, Benjamin Herrenschmidt wrote:
> >  static void hwif_register (ide_hwif_t *hwif)
> >  {
> >  	/* register with global device tree */
> >  	strlcpy(hwif->gendev.bus_id,hwif->name,BUS_ID_SIZE);
> >  	hwif->gendev.driver_data = hwif;
> > +	if (hwif->gendev.parent == NULL) {
> >  	if (hwif->pci_dev)
> >  		hwif->gendev.parent = &hwif->pci_dev->dev;
> >  	else
> >  		hwif->gendev.parent = NULL; /* Would like to do = &device_legacy */
> > +	}
> 
> inner if() should be indented

Ah shit, I keep fixing that and for some reason, it keeps re-breaking...
I must have confused bitkeeper someway

Anyway, Bart, you know how to fix that ;)

Ben.



      reply	other threads:[~2003-08-25 10:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-24 13:05 [PATCH] Fix ide unregister vs. driver model Benjamin Herrenschmidt
2003-08-24 22:23 ` Bartlomiej Zolnierkiewicz
2003-08-25  6:34   ` Benjamin Herrenschmidt
2003-08-25 20:50     ` Bartlomiej Zolnierkiewicz
2003-08-25 20:54       ` viro
2003-08-25 20:59       ` Patrick Mochel
2003-08-25 21:06         ` Bartlomiej Zolnierkiewicz
2003-08-25 10:01 ` insecure
2003-08-25 10:04   ` Benjamin Herrenschmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1061805866.779.51.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=insecure@mail.od.ua \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox