public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] IDE: Fix request handling with ide-default & ATAPI
@ 2003-09-09 18:34 Benjamin Herrenschmidt
  0 siblings, 0 replies; only message in thread
From: Benjamin Herrenschmidt @ 2003-09-09 18:34 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel mailing list, Bartlomiej Zolnierkiewicz

Hi Bart & Linus !

This patch fixes a bug that happens when a request gets to the
IDE layer for a drive using ide-default (that is with no
subdriver attached), like a Power Management request. In this
case, the core will wait for the device status to match
drive->read_stat, but that field contains by default a value
that is not suitable for ATAPI devices. This patch fixes it.

Linus, please apply (already validated with Bart)

diff -urN linux-2.5/drivers/ide/ide-default.c linuxppc-2.5-benh/drivers/ide/ide-default.c
--- linux-2.5/drivers/ide/ide-default.c	2003-09-09 20:15:34.000000000 +0200
+++ linuxppc-2.5-benh/drivers/ide/ide-default.c	2003-09-09 20:05:50.000000000 +0200
@@ -57,6 +57,14 @@
 			"driver with ide.c\n", drive->name);
 		return 1;
 	}
+	
+	/* For the sake of the request layer, we must make sure we have a
+	 * correct ready_stat value, that is 0 for ATAPI devices or we will
+	 * fail any request like Power Management
+	 */
+	if (drive->media != ide_disk)
+		drive->ready_stat = 0;
+
 	return 0;
 }
 



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-09-09 18:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-09-09 18:34 [PATCH] IDE: Fix request handling with ide-default & ATAPI Benjamin Herrenschmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox