From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261268AbTIJJbL (ORCPT ); Wed, 10 Sep 2003 05:31:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261271AbTIJJbL (ORCPT ); Wed, 10 Sep 2003 05:31:11 -0400 Received: from pentafluge.infradead.org ([213.86.99.235]:20153 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S261268AbTIJJbH (ORCPT ); Wed, 10 Sep 2003 05:31:07 -0400 From: Benjamin Herrenschmidt To: cb-lkml@fish.zetnet.co.uk Cc: linux-kernel mailing list In-Reply-To: <20030910092522.GA1916@fish.zetnet.co.uk> References: <20030910090419.GA3673@fish.zetnet.co.uk> <1063185375.1356.64.camel@gaston> <20030910092522.GA1916@fish.zetnet.co.uk> Message-Id: <1063186257.642.67.camel@gaston> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.4 Date: Wed, 10 Sep 2003 11:30:58 +0200 X-SA-Exim-Mail-From: benh@kernel.crashing.org Subject: Re: [PATCH] IDE: Fix Power Management request race on resume Content-Type: text/plain Content-Transfer-Encoding: 7bit X-SA-Exim-Version: 3.0+cvs (built Mon Aug 18 15:53:30 BST 2003) X-SA-Exim-Scanned: Yes X-Pentafluge-Mail-From: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2003-09-10 at 11:25, cb-lkml@fish.zetnet.co.uk wrote: > On Wed, Sep 10, 2003 at 11:16:15AM +0200, Benjamin Herrenschmidt wrote: > > On Wed, 2003-09-10 at 11:04, cb-lkml@fish.zetnet.co.uk wrote: > > > I applied this patch to 2.6.0-test5 and still have this problem: > > > > > > http://marc.theaimsgroup.com/?l=linux-kernel&m=106218353005043&w=2 > > > > There are a couple of other fixes pending though I don't thing > > they are related to your problem. Do you have a slave drive on > > this channel ? What driver are you using for the host controller ? > > Does it have a dma_check() function ? > > It's a laptop, so there's no slave drive. Some laptops have the CD/DVD as a slave > > The host controller is a PIIX4, using CONFIG_BLK_DEV_PIIX. (Presumably > drivers/ide/pci/piix.c) > > $ grep dma_check piix.c > hwif->ide_dma_check = &piix_config_drive_xfer_rate; Can you put some printk in there to verify it's properly called on wakeup and that it actually does something ? Note that problem may be unrelated to the IDE driver, it could also be some APIC problem messing with interrupts... Ben.