From: Vojtech Pavlik <vojtech@suse.cz>
To: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/5] Fix a warning in input.c when CONFIG_PROC_FS is not set
Date: Fri, 19 Sep 2003 21:47:15 +0200 [thread overview]
Message-ID: <10640008352019@twilight.ucw.cz> (raw)
In-Reply-To: <10640008343413@twilight.ucw.cz>
You can pull this changeset from:
bk://kernel.bkbits.net/vojtech/input
===================================================================
ChangeSet@1.1351, 2003-09-19 13:23:54+02:00, lcapitulino@prefeitura.sp.gov.br
input: Fix a warning in input.c when CONFIG_PROC_FS is not set.
input.c | 27 ++++++++++++++++-----------
1 files changed, 16 insertions(+), 11 deletions(-)
===================================================================
diff -Nru a/drivers/input/input.c b/drivers/input/input.c
--- a/drivers/input/input.c Fri Sep 19 14:12:57 2003
+++ b/drivers/input/input.c Fri Sep 19 14:12:57 2003
@@ -678,20 +678,10 @@
return (count > cnt) ? cnt : count;
}
-#endif
-
-struct class input_class = {
- .name = "input",
-};
-
-static int __init input_init(void)
+static int __init input_proc_init(void)
{
struct proc_dir_entry *entry;
- int retval = -ENOMEM;
-
- class_register(&input_class);
-#ifdef CONFIG_PROC_FS
proc_bus_input_dir = proc_mkdir("input", proc_bus);
if (proc_bus_input_dir == NULL)
return -ENOMEM;
@@ -710,7 +700,22 @@
return -ENOMEM;
}
entry->owner = THIS_MODULE;
+ return 0;
+}
+#else /* !CONFIG_PROC_FS */
+static inline int input_proc_init(void) { return 0; }
#endif
+
+struct class input_class = {
+ .name = "input",
+};
+
+static int __init input_init(void)
+{
+ int retval = -ENOMEM;
+
+ class_register(&input_class);
+ input_proc_init();
retval = register_chrdev(INPUT_MAJOR, "input", &input_fops);
if (retval) {
printk(KERN_ERR "input: unable to register char major %d", INPUT_MAJOR);
next prev parent reply other threads:[~2003-09-19 19:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-19 19:47 [PATCH 1/5] input: Fix Set3 keycode for right control in atkbd.c Vojtech Pavlik
2003-09-19 19:47 ` Vojtech Pavlik [this message]
2003-09-19 19:47 ` [PATCH 3/5] Remove a not necessary #ifdef CONFIG_PROC_FS/#endif in input.c Vojtech Pavlik
2003-09-19 19:47 ` [PATCH 4/5] Fix memory leak in hiddev.c found by Stanford Checker Vojtech Pavlik
2003-09-19 19:47 ` [PATCH 5/5] Fix Kconfig KEYBOARD_ATKBD when SERIO is modular Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10640008352019@twilight.ucw.cz \
--to=vojtech@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox