From: Evgeniy Polyakov <zbr@ioremap.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Fries <david@fries.net>,
Matt Campbell <mattrcampbell@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch] [patch 2/2 v2] w1: use correct lock on error in w1_seq_show()
Date: Thu, 11 Jun 2015 18:31:00 +0300 [thread overview]
Message-ID: <1064021434036660@web13o.yandex.ru> (raw)
In-Reply-To: <20150604090412.GE22838@mwanda>
Hi
04.06.2015, 12:04, "Dan Carpenter" <dan.carpenter@oracle.com>:
> I noticed there was a problem here because Smatch complained:
>
> drivers/w1/slaves/w1_therm.c:416 w1_seq_show() warn:
> inconsistent returns 'mutex:&sl->master->mutex'.
> Locked on: line 416
> Unlocked on: line 413
>
> The problem is that we lock ->mutex but we unlock ->bus_mutex on error.
> David Fries says that ->bus_mutex is correct and ->mutex is incorrect.
>
> Fixes: d9411e57dc7f ('w1: Add support for DS28EA00 sequence to w1-therm')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Looks good to me, Greg please pull this serie into your tree, if you hadn't yet.
Am I right that this is a stable tree material too?
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
next prev parent reply other threads:[~2015-06-11 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 9:56 [patch 2/2] w1: unlock correct lock on error in w1_seq_show() Dan Carpenter
2015-06-02 12:12 ` David Fries
[not found] ` <CA+gYwTGSBAjSPyUSUwknOmm8SoFzHFdJmoYPVA9yN61aWO7sdA@mail.gmail.com>
2015-06-03 1:07 ` David Fries
2015-06-03 1:54 ` Matt Campbell
2015-06-03 2:39 ` David Fries
2015-06-04 9:04 ` [patch] [patch 2/2 v2] w1: use " Dan Carpenter
2015-06-11 15:31 ` Evgeniy Polyakov [this message]
2015-06-11 23:41 ` David Fries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1064021434036660@web13o.yandex.ru \
--to=zbr@ioremap.net \
--cc=dan.carpenter@oracle.com \
--cc=david@fries.net \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattrcampbell@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox