Re: [PATCH] i2c driver fixes for 2.6.0-test5

Christoph Hellwig
2003-09-23T08:16:19Z

On Mon, Sep 22, 2003 at 04:30:28PM -0700, Greg KH wrote:
> for (addr = 0x00; addr <= (is_isa ? 0xffff : 0x7f); addr++) {
> - /* XXX: WTF is going on here??? */
> - if ((is_isa && check_region(addr, 1)) ||
> + void *region_used = request_region(addr, 1, "foo");
> + release_region(addr, 1);
> + if ((is_isa && (region_used == NULL)) ||

WTF?? Your papering over bugs again, this doesn't help at all.