From: Arjan van de Ven <arjanv@redhat.com>
To: Ian Kent <raven@themaw.net>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
Maneesh Soni <maneesh@in.ibm.com>,
autofs mailing list <autofs@linux.kernel.org>,
Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH] autofs4 deadlock during expire - kernel 2.6
Date: Wed, 24 Sep 2003 15:09:23 +0200 [thread overview]
Message-ID: <1064408962.5074.2.camel@laptop.fenrus.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0309242059120.4975-100000@raven.themaw.net>
[-- Attachment #1: Type: text/plain, Size: 594 bytes --]
On Wed, 2003-09-24 at 15:01, Ian Kent wrote:
> This is a corrected patch for the autofs4 daedlock problem I posted about
> @@ -206,6 +207,11 @@
>
> interruptible_sleep_on(&wq->queue);
>
> + if (waitqueue_active(&wq->queue) && current != wq->owner) {
> + set_current_state(TASK_INTERRUPTIBLE);
> + schedule_timeout(wq->wait_ctr * (HZ/10));
> + }
> +
this really really looks like you're trying to pamper over a bug by
changing the timing somewhere instead of fixing it...
also are you sure the deadlock isn't because of the racey use of
interruptible_sleep_on ?
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2003-09-24 13:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-24 13:01 [PATCH] autofs4 deadlock during expire - kernel 2.6 Ian Kent
2003-09-24 13:09 ` Arjan van de Ven [this message]
2003-09-24 13:38 ` Ian Kent
2003-09-24 13:57 ` Arjan van de Ven
2003-09-24 14:46 ` Ian Kent
2003-09-24 15:11 ` Arjan van de Ven
2003-09-24 15:54 ` Mike Waychison
2003-09-25 1:44 ` Ian Kent
2003-09-25 11:59 ` [autofs] " Ian Kent
-- strict thread matches above, loose matches on Subject: below --
2003-09-23 13:47 Ian Kent
2003-09-23 15:31 ` Mike Waychison
2003-09-23 16:24 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1064408962.5074.2.camel@laptop.fenrus.com \
--to=arjanv@redhat.com \
--cc=autofs@linux.kernel.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maneesh@in.ibm.com \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox